Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Equals in hot reload scenario #78249

Merged
merged 2 commits into from
Nov 12, 2022
Merged

Conversation

buyaa-n
Copy link
Contributor

@buyaa-n buyaa-n commented Nov 11, 2022

While fixing Hot Reload breaks MethodInfo equality we caused regression in PropertyInfo, FieldInfo and EventInfo.

See details: Huge Breaking Issue in Net7 with MemberInfo equality

Fixes: #78218

@ghost
Copy link

ghost commented Nov 11, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

While fixing Hot Reload breaks MethodInfo equality we caused regression in PropertyInfo, FieldInfo and EventInfo.

See details: Huge Breaking Issue in Net7 with MemberInfo equality

Fixes: #78218

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection

Milestone: -

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Nov 12, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

@buyaa-n
Copy link
Contributor Author

buyaa-n commented Nov 12, 2022

The failure unrelated and reported, merging

@buyaa-n buyaa-n merged commit 52eed7d into dotnet:main Nov 12, 2022
@buyaa-n buyaa-n deleted the equals-regression branch November 12, 2022 03:22
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huge Breaking Issue in Net7 with MemberInfo equality
4 participants