Move dotnet.cmd/sh helper scripts into the repo root #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
changed the title
jkotas
reviewed
Dec 8, 2019
Introducing a dotnet.ps1 wrapper script which invokes the bootstrapping logic so that output in dotnet.cmd isn't swallowed.
…runtime into DotNetHelperScripts
wjk
reviewed
Dec 8, 2019
| __dotnetDir=${_InitializeDotNetCli} | ||
|
|
||
| dotnetPath=${__dotnetDir}/dotnet | ||
| ${dotnetPath} "$@" |
There was a problem hiding this comment.
Suggested change
| ${dotnetPath} "$@" | |
| ${dotnetPath} "$@" | |
| exec ${dotnetPath} "$@" |
trylek
approved these changes
Dec 8, 2019
jkotas
reviewed
Dec 8, 2019
Add the powershell script back and invoke the SDK in the corresponding root script.
To avoid a nested process chain in which the inner process then invokes the host, we instead create a temporary file to store the sdk location.
jkotas
reviewed
Dec 9, 2019
|
I could submit a PR to arcade which handles the temporary file creation and get rid of the dotnet.ps1 here. |
|
Merging as the arcade PR is merged which means we won't loose the changes that I made to the tools.ps1 file. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several people expressed their interest in having the dotnet.cmd/ps1/sh helper scripts, which invoke the correct dotnet, in the repo root. This also improves the local developer workflow as it offers an alternative to invoking the globally installed dotnet.