Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sdk location file for cmd invocations #4531

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Add sdk location file for cmd invocations #4531

merged 1 commit into from
Dec 11, 2019

Conversation

ViktorHofer
Copy link
Member

Fixes #4530

@ViktorHofer ViktorHofer requested a review from jkotas December 10, 2019 17:30
jkotas
jkotas approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ViktorHofer ViktorHofer merged commit 27ebf76 into dotnet:master Dec 11, 2019
@ViktorHofer ViktorHofer deleted the FileSdkHelper branch December 11, 2019 19:56
@ViktorHofer ViktorHofer mentioned this pull request Dec 11, 2019
Merged
@ViktorHofer
Copy link
Member Author

@tmat submitted a follow-up PR to address your suggestions: #4546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmat tmat tmat left review comments

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bootstrapping the SDK form a cmd script is non-trivial today
3 participants
@ViktorHofer @tmat @jkotas