Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in managed port of strong name validation #66554

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 13, 2022

Fixes #66545

@jkotas
Copy link
Member Author

jkotas commented Mar 13, 2022

@VSadov This is a bug in the managed port of AssemblyName. It is affecting all runtimes now that we have switched to managed implementation of the AssemblyName everywhere.

I was actually thinking about deleting this strong name key validation instead. It is useless in CoreCLR. CoreCLR can treat the strong name key as opaque blob. What do you think?

@VSadov
Copy link
Member

VSadov commented Mar 13, 2022

I was actually thinking about deleting this strong name key validation instead. It is useless in CoreCLR. CoreCLR can treat the strong name key as opaque blob. What do you think?

The validation does not seem to be very expensive. We basically sanity-check the size and hash/alg IDs.
My concern is that once we relax the validation, more cases will become valid and may potentially break some tool or whatever took dependency on these constraints that we check now.
If there is not a lot to gain by relaxing, but there is some, even though low, probability of breaking, maybe we should just keep it?

Copy link
Member

@VSadov VSadov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jkotas
Copy link
Member Author

jkotas commented Mar 14, 2022

@VSadov Have you just created the area-runtime label? The issue automation expects to have all area- labels associated with owners in https://github.com/dotnet/runtime/blob/main/docs/area-owners.md .

@jkotas
Copy link
Member Author

jkotas commented Mar 14, 2022

All failures are timeouts. Helix running out of capacity?

@jkotas jkotas merged commit d110d7d into dotnet:main Mar 14, 2022
@jkotas jkotas deleted the issue-66545 branch March 14, 2022 02:55
@teo-tsirpanis
Copy link
Contributor

FYI area-runtime came from issues transferred from ASP.NET Core. (#62032 (comment))

@VSadov
Copy link
Member

VSadov commented Mar 14, 2022

Yes. I could not place this in a particular runtime, since this is in a shared component (so not strictly coreclr or mono or NativeAOT), then I noticed area-runtime and used it. It was already in the list.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terrafx.interop.windows and Assembly.FullName problem when compile using NativeAOT
4 participants