-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix typo in managed port of strong name validation #66554
Conversation
@VSadov This is a bug in the managed port of AssemblyName. It is affecting all runtimes now that we have switched to managed implementation of the AssemblyName everywhere. I was actually thinking about deleting this strong name key validation instead. It is useless in CoreCLR. CoreCLR can treat the strong name key as opaque blob. What do you think? |
The validation does not seem to be very expensive. We basically sanity-check the size and hash/alg IDs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@VSadov Have you just created the |
All failures are timeouts. Helix running out of capacity? |
FYI |
Yes. I could not place this in a particular runtime, since this is in a shared component (so not strictly coreclr or mono or NativeAOT), then I noticed |
Fixes #66545