-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Spaces from GitHub Labels #62032
Comments
I'd opt for no surrounding dashes. Color + ALL-CAPS should be enough to make those pop. |
changes are fine with me, when we've changed label strings in the past there was little fallout: it seems that not many people bookmark queries. |
BTW, I wonder whether there are any emerging standards across other dotnet repos, or repos in general? It looks like https://up-for-grabs.net/ is fairly agnostic. It looks like https://github.com/microsoft/vscode/labels standardized on lower case kebab. |
Thanks for the notes there, @danmoseley. I'm going to wait a couple days into next week before taking any action to make sure folks get to see this after the long US holiday weekend. |
Given that we plan to rename "feature request" ... why do we even have this label? It is duplicate of 'enhancement' label. Instead of renaming, should we just merge it? (happy to take it separately if needed / desired) |
By the way -- with FabricBot configuration being moved to Config-As-Code (#62297) it should be fairly straightforward to bulk rename labels that are touched by automation. |
My 2c I have no objection to any of the changes proposed. |
I just merged #64048 which completed conversion of all labels impacted by FB automation. |
Copying a discussion item from the
Somebody with the necessary permissions could evaluate each label and delete it from The
Also the Somebody with the necessary permissions could evaluate each label and synchronize its naming on |
I've made all of the changes (including the cleanup identified by @teo-tsirpanis) except for those that require changes to themesof.net. That will need to be coordinated with @terrajobst and it potentially affects other repos as well. |
Since
Bottom Up Work
|
There have been several offline conversations recently about the spaces in use within labels in this repo. Common comments include:
I propose that we standardize on dashes and update existing labels with spaces to conform to dashes instead. Here is what would be affected if we adopted that approach:
Bottom Up Work
➡️bottom-up-work
(requires themesof.net change)Continuous Improvement
: Unused; could be deleted or changed tocontinuous-improvement
(requires themesof.net change)Design Discussion
➡️design-discussion
diagnostic global tooling
: Only used by 7 closed issues; could be deleted or changed todiagnostic-global-tooling
feature request
➡️feature
(for symmetry withbug
) orfeature-request
FollowingUp
➡️ Very low usage with only 1 (stale) open issue; could be deleted, changed tofollowing-up
, or merged withneeds-further-triage
hard problem
➡️hard-problem
(or considerdifficulty:hard
witheasy
➡️difficulty:easy
)in pr
➡️in-pr
(impacts automation)needs further triage
➡️needs-further-triage
(impacts automation)needs more info
➡️needs-more-info
(impacts automation)* NO MERGE *
➡️-NO-MERGE-
orNO-MERGE
* NO SQUASH *
➡️-NO-SQUASH-
orNO-SQUASH
NO REVIEW
➡️-NO-REVIEW-
orNO-REVIEW
no recent activity
➡️no-recent-activity
(impacts automation)release notes
➡️release-notes
test bug
➡️test-bug
test enhancement
➡️test-enhancement
User Story
➡️User-Story
(requires themesof.net change)/cc @terrajobst, @jeffschwMSFT, @danmoseley, @marek-safar
The text was updated successfully, but these errors were encountered: