Escape lower-cased type names

[jcouv]

A warnlevel 7 warning is being added in VS 17.1 / SDK 6.0.200 to warn about lower-cased ascii type names. (See PR).

[ghost]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[jaredpar]

Interesting. Most seem to be testing types in the DLR / CSharp dynamic binder code which effectively we own. Looks like a handful of other types hit this but it is more common than I would've expected.

[danmoseley]

Can we just fix the casing? I assume they're all internal and we wouldn't write new code this way. Unless you want to dog food your warning.

[jcouv]

Can we just fix the casing?

That's an option too, but is a bit more work. So you tell me what you'd like ;-)
How about upper-casing the ones in the product code, but leaving the tests merely escaped?

[danmoseley]

I'd prefer to upper case them all, but if that's a hassle this change is OK to me.

[jcouv]

Thanks for letting me know. I'll take a stab.

[jcouv]

How should rtmsg, nlmsgerr and nlmsghdr be capitalized?

[ghost]

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

---

A warnlevel 7 warning is being added in VS 17.1 / SDK 6.0.200 to warn about lower-cased ascii type names. (See PR).

Author:	jcouv
Assignees:	jcouv
Labels:	area-Meta
Milestone:	-

[stephentoub]

How should rtmsg, nlmsgerr and nlmsghdr be capitalized?

I'd prefer to leave these lower-cased. We have a policy that types/functions declared in C# for interop should mirror the native naming, as if we were able to simply reference a .h file. On Unix, that invariably means lower-cased names.

[jcouv]

Then hostent, cgroups, procfs should be left lower-cased too?

[stephentoub]

Then hostent, cgroups, procfs should be left lower-cased too?

Similarly my preference is for those to remain lower-cased as well.

[danmoseley]

Thanks

[kasperk81]

merged with libraries builds failing, affecting everyone else