Escape lower-cased type names (#62507)

Author: jcouv

src/coreclr/tools/dotnet-pgo/CommandLineOptions.cs

@@ -33,7 +33,7 @@ internal class CommandLineOptions
         public bool IncludeFullGraphs;
         public int SpgoMinSamples = 50;
         public bool VerboseWarnings;
-        public jittraceoptions JitTraceOptions;
+        public JitTraceOptions JitTraceOptions;
         public double ExcludeEventsBefore;
         public double ExcludeEventsAfter;
         public bool Warnings;
@@ -211,7 +211,7 @@ void HelpOption()
                 HelpOption();
             }
 
-            JitTraceOptions = jittraceoptions.none;
+            JitTraceOptions = JitTraceOptions.none;
 #if DEBUG
             // Usage of the jittrace format requires using logic embedded in the runtime repository and isn't suitable for general consumer use at this time
             // Build it in debug and check builds to ensure that it doesn't bitrot, and remains available for use by developers willing to build the repo
@@ -230,14 +230,14 @@ void HelpOption()
                 syntax.DefineOption(name: "sorted", value: ref sorted, help: "Generate sorted output.", requireValue: false);
                 if (sorted)
                 {
-                    JitTraceOptions |= jittraceoptions.sorted;
+                    JitTraceOptions |= JitTraceOptions.sorted;
                 }
 
                 bool showtimestamp = false;
                 syntax.DefineOption(name: "showtimestamp", value: ref showtimestamp, help: "Show timestamps in output.", requireValue: false);
                 if (showtimestamp)
                 {
-                    JitTraceOptions |= jittraceoptions.showtimestamp;
+                    JitTraceOptions |= JitTraceOptions.showtimestamp;
                 }
 
                 syntax.DefineOption(name: "includeReadyToRun", value: ref ProcessR2REvents, help: "Include ReadyToRun methods in the trace file.", requireValue: false);

src/coreclr/tools/dotnet-pgo/Program.cs

@@ -41,7 +41,7 @@ public enum PgoFileType
     }
 
     [Flags]
-    public enum jittraceoptions
+    public enum JitTraceOptions
     {
         none = 0,
         sorted = 1,
@@ -1650,7 +1650,7 @@ void AddToInstrumentationData(int eventClrInstanceId, long methodID, int methodF
             return 0;
         }
 
-        static void GenerateJittraceFile(FileInfo outputFileName, IEnumerable<ProcessedMethodData> methodsToAttemptToPrepare, jittraceoptions jittraceOptions)
+        static void GenerateJittraceFile(FileInfo outputFileName, IEnumerable<ProcessedMethodData> methodsToAttemptToPrepare, JitTraceOptions jittraceOptions)
         {
             PrintMessage($"JitTrace options {jittraceOptions}");
 
@@ -1677,7 +1677,7 @@ static void GenerateJittraceFile(FileInfo outputFileName, IEnumerable<ProcessedM
                 try
                 {
                     string timeStampAddon = "";
-                    if (jittraceOptions.HasFlag(jittraceoptions.showtimestamp))
+                    if (jittraceOptions.HasFlag(JitTraceOptions.showtimestamp))
                         timeStampAddon = time.ToString("F4") + "-";
 
                     methodPrepareInstruction.Append(CsvEscape(timeStampAddon + method.ToString(), outerCsvEscapeChar));
@@ -1712,7 +1712,7 @@ static void GenerateJittraceFile(FileInfo outputFileName, IEnumerable<ProcessedM
                 }
             }
 
-            if (jittraceOptions.HasFlag(jittraceoptions.sorted))
+            if (jittraceOptions.HasFlag(JitTraceOptions.sorted))
             {
                 methodsToPrepare.Sort();
             }

src/libraries/Common/src/Interop/Interop.Ldap.cs

@@ -120,19 +120,19 @@ internal sealed class LDAP_TIMEVAL
     }
 
     [StructLayout(LayoutKind.Sequential)]
-    internal sealed class berval
+    internal sealed class BerVal
     {
         public int bv_len;
         public IntPtr bv_val = IntPtr.Zero;
 
-        public berval() { }
+        public BerVal() { }
     }
 
     [StructLayout(LayoutKind.Sequential, CharSet = CharSet.Unicode)]
     internal sealed class LdapControl
     {
         public IntPtr ldctl_oid = IntPtr.Zero;
-        public berval ldctl_value;
+        public BerVal ldctl_value;
         public bool ldctl_iscritical;
 
         public LdapControl() { }

src/libraries/Common/src/Interop/Interop.zlib.cs

@@ -6,7 +6,7 @@
 
 internal static partial class Interop
 {
-    internal static partial class zlib
+    internal static partial class ZLib
     {
         [GeneratedDllImport(Libraries.CompressionNative, EntryPoint = "CompressionNative_DeflateInit2_")]
         internal static unsafe partial ZLibNative.ErrorCode DeflateInit2_(

src/libraries/Common/src/Interop/Linux/OpenLdap/Interop.Ber.cs

@@ -18,7 +18,7 @@ internal static partial class Ldap
 #pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
         // TODO: [DllImportGenerator] Switch to use GeneratedDllImport once we support non-blittable structs.
         [DllImport(Libraries.OpenLdap, EntryPoint = "ber_init", CharSet = CharSet.Ansi)]
-        public static extern IntPtr ber_init(berval value);
+        public static extern IntPtr ber_init(BerVal value);
 #pragma warning restore DLLIMPORTGENANALYZER015
 
         [GeneratedDllImport(Libraries.OpenLdap, EntryPoint = "ber_free", CharSet = CharSet.Ansi)]

src/libraries/Common/src/Interop/Linux/OpenLdap/Interop.Ldap.cs

@@ -164,7 +164,7 @@ static Ldap()
 #pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
         // TODO: [DllImportGenerator] Switch to use GeneratedDllImport once we support non-blittable structs.
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_sasl_bind_s", CharSet = CharSet.Ansi)]
-        internal static extern int ldap_sasl_bind(ConnectionHandle ld, string dn, string mechanism, berval cred, IntPtr serverctrls, IntPtr clientctrls, IntPtr servercredp);
+        internal static extern int ldap_sasl_bind(ConnectionHandle ld, string dn, string mechanism, BerVal cred, IntPtr serverctrls, IntPtr clientctrls, IntPtr servercredp);
 #pragma warning restore DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
 
         [GeneratedDllImport(Libraries.OpenLdap, EntryPoint = "ldap_sasl_interactive_bind_s", CharSet = CharSet.Ansi)]
@@ -176,7 +176,7 @@ static Ldap()
 #pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
         // TODO: [DllImportGenerator] Switch to use GeneratedDllImport once we support non-blittable structs.
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_extended_operation", CharSet = CharSet.Ansi)]
-        public static extern int ldap_extended_operation(ConnectionHandle ldapHandle, string oid, berval data, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
+        public static extern int ldap_extended_operation(ConnectionHandle ldapHandle, string oid, BerVal data, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
 #pragma warning restore DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
 
         [GeneratedDllImport(Libraries.OpenLdap, EntryPoint = "ldap_first_attribute", CharSet = CharSet.Ansi)]
@@ -236,7 +236,7 @@ static Ldap()
 #pragma warning disable DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
         // TODO: [DllImportGenerator] Switch to use GeneratedDllImport once we support non-blittable structs.
         [DllImport(Libraries.OpenLdap, EntryPoint = "ldap_compare_ext", CharSet = CharSet.Ansi)]
-        public static extern int ldap_compare(ConnectionHandle ldapHandle, string dn, string attributeName, berval binaryValue, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
+        public static extern int ldap_compare(ConnectionHandle ldapHandle, string dn, string attributeName, BerVal binaryValue, IntPtr servercontrol, IntPtr clientcontrol, ref int messageNumber);
 #pragma warning restore DLLIMPORTGENANALYZER015 // Use 'GeneratedDllImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time
     }
 }

src/libraries/Common/src/Interop/Linux/cgroups/Interop.cgroups.cs

@@ -10,7 +10,7 @@
 internal static partial class Interop
 {
     /// <summary>Provides access to some cgroup (v1 and v2) features</summary>
-    internal static partial class cgroups
+    internal static partial class @cgroups
     {
         // For cgroup v1, see https://www.kernel.org/doc/Documentation/cgroup-v1/
         // For cgroup v2, see https://www.kernel.org/doc/Documentation/cgroup-v2.txt

src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.TryReadStatusFile.cs

@@ -12,7 +12,7 @@
 
 internal static partial class Interop
 {
-    internal static partial class procfs
+    internal static partial class @procfs
     {
         internal const string RootPath = "/proc/";
         private const string StatusFileName = "/status";

src/libraries/Common/src/Interop/Linux/procfs/Interop.ProcFsStat.cs

@@ -11,7 +11,7 @@
 
 internal static partial class Interop
 {
-    internal static partial class procfs
+    internal static partial class @procfs
     {
         private const string ExeFileName = "/exe";
         private const string CmdLineFileName = "/cmdline";