[release/5.0] Add check for running under translation to mac installers #60771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOs runs installers built for pre-Big-Sur under rosetta. Detect this and redirect to x64 subdirectory.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
joeloff
approved these changes
Oct 22, 2021
Member
Author
|
Approved for servicing over mail. |
Ported from a C# task which requires quote escaping, here this is actual distribution file which does not need escaping.
NikolaMilosavljevic
approved these changes
Oct 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of dotnet/arcade#8084
Customer Impact
Installing x64 runtime bundle result in bits being installed to the wrong location.
Testing
Manual installation on M1 to confirm fix
Risk
Low. This change was made and tested in main and has been present there for a month. I missed it when collecting all the commits for backport.