-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI matrix change: Add OSX 12 arm #59085
Changes from 2 commits
a627ba0
64f2806
369da89
7d37886
a9d16d5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -90,6 +90,7 @@ jobs: | |
# OSX arm64 | ||
- ${{ if eq(parameters.platform, 'OSX_arm64') }}: | ||
- OSX.1100.ARM64.Open | ||
- OSX.1200.ARM64.Open | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just curious, how can I tell this is libraries tests, as opposed eg to CLR tests ? It's not clear to me - I'm not familiar with how this works. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ad far as I understand But it is still black box for me how it is orchestrated. @ViktorHofer is there any docs available? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file associates the queue to platform. To see if it runs, you'll have to check the runtime ymls to see if the platform is defined. A quick spot check looks like osx-arm64 is defined only for the runtime tests. Actually, I stand corrected. It's in runtime-staging. It looks like it's only configured for the rolling build. |
||
|
||
# OSX x64 | ||
- ${{ if eq(parameters.platform, 'OSX_x64') }}: | ||
|
@@ -110,6 +111,7 @@ jobs: | |
# iOS Simulator/Mac Catalyst arm64 | ||
- ${{ if in(parameters.platform, 'MacCatalyst_arm64', 'iOSSimulator_arm64') }}: | ||
- OSX.1100.ARM64.Open | ||
- OSX.1200.ARM64.Open | ||
|
||
# iOS/tvOS simulator x64/x86 & MacCatalyst x64 | ||
- ${{ if in(parameters.platform, 'iOSSimulator_x64', 'iOSSimulator_x86', 'tvOSSimulator_x64', 'MacCatalyst_x64') }}: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is 1500? I assumed that on Arm64, macOS followed the same version numbering -- ie macOS 11 or macOS12. Is that not right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is mistake, it should be 1200