-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI matrix change: Add OSX 12 arm #59085
CI matrix change: Add OSX 12 arm #59085
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
@@ -107,7 +107,7 @@ jobs: | |||
# OSX arm64 | |||
- ${{ if eq(parameters.platform, 'OSX_arm64') }}: | |||
- ${{ if and(eq(variables['System.TeamProject'], 'public'), in(parameters.jobParameters.helixQueueGroup, 'pr', 'ci', 'libraries')) }}: | |||
- OSX.1100.ARM64.Open | |||
- OSX.1500.ARM64.Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is 1500? I assumed that on Arm64, macOS followed the same version numbering -- ie macOS 11 or macOS12. Is that not right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is mistake, it should be 1200
@@ -90,6 +90,7 @@ jobs: | |||
# OSX arm64 | |||
- ${{ if eq(parameters.platform, 'OSX_arm64') }}: | |||
- OSX.1100.ARM64.Open | |||
- OSX.1200.ARM64.Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, how can I tell this is libraries tests, as opposed eg to CLR tests ? It's not clear to me - I'm not familiar with how this works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ad far as I understand
CLR: eng/pipelines/coreclr/templates/helix-queues-setup.yml
Libs: eng/pipelines/libraries/helix-queues-setup.yml
But it is still black box for me how it is orchestrated.
@ViktorHofer is there any docs available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file associates the queue to platform. To see if it runs, you'll have to check the runtime ymls to see if the platform is defined. A quick spot check looks like osx-arm64 is defined only for the runtime tests.
Actually, I stand corrected. It's in runtime-staging. It looks like it's only configured for the rolling build.
@ViktorHofer, @danmoseley, all test passes, we can add this queue once we have more resources on Helix side. |
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsChanges in CI matrix:
part of #57947
|
I didn't check the yml. Does this added queue only run as part of a rolling build? If so, can you please queue up a build with your changes to make sure that the changes work as expected? |
Looks to only run on the rolling build runtime/eng/pipelines/runtime-staging.yml Line 497 in 8bba6fb
|
We are waiting for available HW in the CI queue. |
Update: Last info from infra team is that we are blocked on HW availability: https://github.com/dotnet/core-eng/issues/14309#issuecomment-946909143 |
@ericstj whom should we reassign it to, to track the new HW availability and then merge? |
Looks like https://github.com/dotnet/core-eng/issues/13921 tracks availability. @aik-jahoda, do we have a recent update? Looks like the last info was 1.5 months ago, it's possible things have changed. Perhaps @MattGal or @ilyas1974 might know. If not, then I'd suggest just closing this PR and making sure we have an issue filed under milestone 7.0.0 tracking adding this back when resources are available. CC @agocke |
Looks like we've got about 10 machines on osx.1200.arm64 and 57 on osx.1200.arm64.open ready for your usage now, so please give it a shot and let us know how it goes. Right now, usage is very light but if a bunch of teams migrate stuff there at once (especially if a lot of the work crashes and has to upload dumps) we may find this to be insufficient, but right now the queues are practically idle so party on, and let me know (or the FR teams channel) if you hit any issues. |
@AaronRobinsonMSFT any thoughts about this one?
|
Looks like that's the only failure on macOS 12 ARM. There's also a crash in Mono but on x64. |
@danmoseley I've no idea on this one. I don't know of any work in this product area recently so will assume it is either something flakey on the OS side or perhaps something in the test revamp that has been going on. This test does have special scripting logic so it is possible some disturbance was introduced. Any thoughts on the above @jkoritzinsky? |
This is obsolete now |
Changes in CI matrix:
part of #57947