Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Remove SupportedOSPlatforms windows on Hosting WindowsServices #59064

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2021

Backport of #59039 to release/6.0

/cc @eerhardt

Customer Impact

We've received feedback customers do not like that they are getting warnings when calling Hosting's UseWindowsService APIs when their application isn't targeting "windows" specifically.

  1. The Hosting UseWindowsService is intended to "light up" when running in a windows service process, but the hosted app still works when run on non-Windows. This allows developers to test their apps on mac/linux dev machines without deploying to a windows machine.
  2. Some hosted apps are "cross platform" and call both UseWindowsService and UseSystemd APIs. Then depending on which platform they are running, the correct logic lights up.

This change removes the "windows" specific SupportedOSPlatform attribute, so customers will no longer get a build time warning in applications that aren't explicitly targeting windows TFMs.

Testing

Tested that warnings are no longer raised. All existing tests still pass.

Risk

Very low

@ghost
Copy link

ghost commented Sep 13, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #59039 to release/6.0

/cc @eerhardt

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@danmoseley
Copy link
Member

Approved. Customer feedback on new feature, fixes a regression (arguably), very low risk.

@danmoseley danmoseley added the Servicing-approved Approved for servicing release label Sep 13, 2021
@eerhardt
Copy link
Member

I think this can be merged. The runtime-staging OSX legs timed out due to infrastructure issues, but all the runtime legs passed.

@danmoseley danmoseley merged commit 130a956 into release/6.0 Sep 15, 2021
@danmoseley danmoseley deleted the backport/pr-59039-to-release/6.0 branch September 15, 2021 02:27
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants