Remove SupportedOSPlatforms windows on Hosting WindowsServices #59039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eerhardt, @maryamariyan |
Tratcher
approved these changes
Sep 13, 2021
|
failures are #58927 |
jeffhandley
approved these changes
Sep 13, 2021
buyaa-n
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Per an email conversation, this change sets the precedent that we can omit attributes in cases where the API connotes the platform support by name or docs summary, and no-ops on other platforms.
I wonder what if the developer doesn't know the API was no-op for other platforms, but for this assembly, it looks good to me as the assembly name indicates it is for Windows only
|
Merging. Failures are infrastructure and flaky networking. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1231195784 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #59037