Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nullable improvement for Microsoft.Extensions.Primitives.StringSegment #58264

Merged
merged 1 commit into from
Aug 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public partial interface IChangeToken
public StringSegment(string buffer, int offset, int length) { throw null; }
public string? Buffer { get { throw null; } }
[System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, nameof(Buffer))]
[System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, nameof(Value))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - @stephentoub. Now there are 2 public usages of this attribute 😄.

#57395 (comment)

public bool HasValue { get { throw null; } }
public char this[int index] { get { throw null; } }
public int Length { get { throw null; } }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ public StringSegment(string buffer, int offset, int length)
/// Gets whether this <see cref="StringSegment"/> contains a valid value.
/// </summary>
[MemberNotNullWhen(true, nameof(Buffer))]
[MemberNotNullWhen(true, nameof(Value))]
public bool HasValue => Buffer != null;

/// <summary>
Expand Down