Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nullable improvement for Microsoft.Extensions.Primitives.StringSegment #58264

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Nullable improvement for Microsoft.Extensions.Primitives.StringSegment #58264

merged 1 commit into from
Aug 27, 2021

Conversation

maxkoshevoi
Copy link
Contributor

No description provided.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 27, 2021
@ghost
Copy link

ghost commented Aug 27, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: maxkoshevoi
Assignees: -
Labels:

new-api-needs-documentation, area-Extensions-Primitives
Milestone: -

@maxkoshevoi maxkoshevoi mentioned this pull request Aug 27, 2021
Merged
eerhardt
eerhardt approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this up!

src/libraries/Microsoft.Extensions.Primitives/ref/Microsoft.Extensions.Primitives.cs
@@ -45,6 +45,7 @@ public partial interface IChangeToken
public StringSegment(string buffer, int offset, int length) { throw null; }
public string? Buffer { get { throw null; } }
[System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, nameof(Buffer))]
[System.Diagnostics.CodeAnalysis.MemberNotNullWhen(true, nameof(Value))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI - @stephentoub. Now there are 2 public usages of this attribute 😄.

#57395 (comment)

@dougbu
Copy link
Member

dougbu commented Aug 27, 2021

This is approved and it would be great to have a build including this for dotnet/aspnetcore#35547 without pulling in lots of other nullability changes.

  1. Have other nullability PRs been merged since the 20210827.1 build❔
  2. Could this be merged ASAP❔

@eerhardt eerhardt merged commit a579575 into dotnet:main Aug 27, 2021
@eerhardt
Copy link
Member

Have other nullability PRs been merged since the 20210827.1 build❔

There were 2 other nullabillity PRs merged 2 days ago:

#57405
#57409

@dougbu
Copy link
Member

dougbu commented Aug 27, 2021

@eerhardt eerhardt merged commit a579575 into dotnet:main 8 minutes ago

Thanks❕ I'll watch the next dotnet-runtime-official build.

There were 2 other nullabillity PRs merged 2 days ago

Yup. I'm working on my reaction to those additional changes in dotnet/aspnetcore#35547.

@maxkoshevoi maxkoshevoi deleted the mk/primitives-fix-3 branch August 27, 2021 22:12
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

Assignees
No one assigned
Labels
area-Extensions-Primitives community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxkoshevoi @dougbu @eerhardt