Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete suspicious code in RuntimeType #52535

Closed
wants to merge 2 commits into from
Closed

Delete suspicious code in RuntimeType #52535

wants to merge 2 commits into from

Commits on May 10, 2021

  1. Delete suspicious code in RuntimeType 

    This code indicates that we can somehow get to fields on interfaces by reflecting on fields of a type implementing the interface. If that's the case, we have work to do in IL Linker. But I have not been able to find a way to do that, mostly because static fields don't get inherited the same as instance fields and we don't allow instance fields on interfaces.

Deleting the code to see if we have any failing tests.
    @MichalStrehovsky
    MichalStrehovsky authored May 10, 2021
    Configuration menu
    Copy the full SHA
    6683974 View commit details
    Browse the repository at this point in the history

  2. Update RuntimeType.CoreCLR.cs

    @MichalStrehovsky
    MichalStrehovsky authored May 10, 2021
    Configuration menu
    Copy the full SHA
    5f681dc View commit details
    Browse the repository at this point in the history