Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links in docs/README.md #441

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Conversation

Youssef1313
Copy link
Member

  • Made links from http to https
  • Updated link from MSDN to docs
  • Left blank lines around lists. See MD032.

@Youssef1313
Copy link
Member Author

Does this PR helps with #99 (comment) ?
cc @ViktorHofer @Anipik

@ghost
Copy link

ghost commented Dec 2, 2019

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 2 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ViktorHofer
Copy link
Member

@msftbot why haven't you merged the PR yet? 😢

@ViktorHofer
Copy link
Member

@Anipik I can't start a conversation with @msftbot :(

@jkotas jkotas merged commit a61f722 into dotnet:master Dec 2, 2019
@Anipik
Copy link
Contributor

Anipik commented Dec 2, 2019

@ViktorHofer currently the bot depends on the number of checks that needs to be passed in order for the auto-merge to be triggered. This condition is present because azure dev ops takes time to load all the checks.
I will start talking with fabrics team when we have some finished the live ci stuff and concretely knows how the number of checks will vary.

@ViktorHofer
Copy link
Member

Can't the bot just check for all checks passed, similar to how Maestro decides when to merge the auto PRs?

@Anipik
Copy link
Contributor

Anipik commented Dec 2, 2019

yes but sometimes the status shows "all checks passed" but all the checks have not yet been initialized.
eg at the start time WIP and one other check are green but the other checks has not been initialized.
I have added a time delay of 12 mins after the label has been applied but this hack does not ensure that the all the azure checks have been initialized.

@Youssef1313 Youssef1313 deleted the patch-3 branch December 2, 2019 18:49
@ViktorHofer
Copy link
Member

@mmitche @jcagme how did dependency flow (Darc/Maestro) solve the detection of [AllChecksSuccessful]?

@mmitche
Copy link
Member

mmitche commented Dec 2, 2019

It ignores specific checks. So for instance, the license/cla and WIP checks are ignored by default for the standard auto-merge policy, along with one other one i can't remember. If you have additional automated bots that show up in the checks API but aren't part of the actual checks you want to have passing, then you can either set the policy so that it ignores those individual checks, or we can make it one of the defaults that is ignored, if it's used across a bunch of repos.

@Anipik
Copy link
Contributor

Anipik commented Dec 2, 2019

Thanks @mmitche. I will try to follow this lead

safern pushed a commit that referenced this pull request Dec 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants