-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update links in docs/README.md #441
Conversation
Youssef1313
commented
Dec 2, 2019
- Made links from http to https
- Updated link from MSDN to docs
- Left blank lines around lists. See MD032.
Does this PR helps with #99 (comment) ? |
Hello @ViktorHofer! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 10 minutes, a condition that will be fulfilled in about 2 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@msftbot why haven't you merged the PR yet? 😢 |
@Anipik I can't start a conversation with @msftbot :( |
@ViktorHofer currently the bot depends on the number of checks that needs to be passed in order for the auto-merge to be triggered. This condition is present because azure dev ops takes time to load all the checks. |
Can't the bot just check for all checks passed, similar to how Maestro decides when to merge the auto PRs? |
yes but sometimes the status shows "all checks passed" but all the checks have not yet been initialized. |
It ignores specific checks. So for instance, the license/cla and WIP checks are ignored by default for the standard auto-merge policy, along with one other one i can't remember. If you have additional automated bots that show up in the checks API but aren't part of the actual checks you want to have passing, then you can either set the policy so that it ignores those individual checks, or we can make it one of the defaults that is ignored, if it's used across a bunch of repos. |
Thanks @mmitche. I will try to follow this lead |