Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the auto-merge bot #99

Closed
ViktorHofer opened this issue Nov 18, 2019 · 10 comments
Closed

Enable the auto-merge bot #99

ViktorHofer opened this issue Nov 18, 2019 · 10 comments
Assignees
Milestone

Comments

@ViktorHofer
Copy link
Member

Seems the auto-merge bot isn't triggering for dotnet/runtime: #91 (comment). Probably a config switch somewhere?

cc @Anipik @danmosemsft

@danmoseley
Copy link
Member

@Anipik can you please reach out to the fabric bot team to onboard this repo

@Anipik
Copy link
Contributor

Anipik commented Nov 18, 2019

yes i will do that

@Anipik
Copy link
Contributor

Anipik commented Nov 18, 2019

I have setup the config and onborading. We can close this issue after we have tested it with some prs.

@ViktorHofer
Copy link
Member Author

@Anipik what's the status on this?

@Anipik
Copy link
Contributor

Anipik commented Nov 25, 2019

@ViktorHofer I need a pr which is ready to go in to test this.

@ViktorHofer
Copy link
Member Author

ViktorHofer commented Nov 25, 2019

I recommend to just fix a typo in the docs and create a PR yourself. That's what @MattGal often does when he wants to test the CI health. We have thousands of them. But pls wait until #251 is merged to avoid conflicts.

@Anipik
Copy link
Contributor

Anipik commented Nov 25, 2019

okay sure.

@ViktorHofer
Copy link
Member Author

@Anipik kindly asking for a status. The last time I tried the auto-merge bot, it posted the expected message but didn't merge the PR. Thanks.

@Anipik
Copy link
Contributor

Anipik commented Dec 26, 2019

fabrics team deployed our requirement if auto-merging the pr when the runtime check is passed. This will resolve our issues. I updated the tasks today.

@Anipik Anipik closed this as completed Dec 26, 2019
@Anipik
Copy link
Contributor

Anipik commented Dec 26, 2019

Auto-merge wont work on documentation prs as they dont run the runtime check.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants