Skip to content

Conversation

@stephentoub
Copy link
Member

Fixes #43293
Fixes #43292

@ghost
Copy link

ghost commented Oct 12, 2020

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

@ManickaP
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@geoffkizer
Copy link
Contributor

WinHttpHandler targets netstandard2.0 and still erroneously uses DeflateStream rather than ZlibStream for deflate.

This is in our code in WinHttpHandler, right? Not in winhttp proper?

@stephentoub
Copy link
Member Author

This is in our code in WinHttpHandler, right? Not in winhttp proper?

Correct.

else if ((manuallyProcessedDecompressionMethods & DecompressionMethods.Deflate) == DecompressionMethods.Deflate &&
CharArrayHelpers.EqualsOrdinalAsciiIgnoreCase(EncodingNameDeflate, buffer, contentEncodingStartIndex, contentEncodingLength))
{
decompressedStream = new DeflateStream(responseStream, CompressionMode.Decompress);
stripEncodingHeaders = true;
}

This didn't seem like a good enough reason to start shipping a new asset.

@stephentoub
Copy link
Member Author

This didn't seem like a good enough reason to start shipping a new asset.

Though, we could use reflection...

@stephentoub stephentoub merged commit 40fa723 into dotnet:master Oct 13, 2020
@stephentoub stephentoub deleted the fixhttptests branch October 13, 2020 17:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
@karelz karelz added this to the 6.0.0 milestone Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.