Skip to content

Commit 40fa723

Browse files
authored
Fix WinHttpHandler outerloop tests for deflate (#43305)
1 parent 385a0c6 commit 40fa723

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.Decompression.cs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ await server.AcceptConnectionAsync(async connection =>
171171

172172
[OuterLoop("Uses external servers")]
173173
[Theory, MemberData(nameof(RemoteServersAndCompressionUris))]
174-
public async Task GetAsync_SetAutomaticDecompression_ContentDecompressed(Configuration.Http.RemoteServer remoteServer, Uri uri)
174+
public async Task GetAsync_SetAutomaticDecompression_ContentDecompressed_GZip(Configuration.Http.RemoteServer remoteServer, Uri uri)
175175
{
176176
// Sync API supported only up to HTTP/1.1
177177
if (!TestAsync && remoteServer.HttpVersion.Major >= 2)
@@ -205,10 +205,14 @@ public async Task GetAsync_SetAutomaticDecompression_ContentDecompressed(Configu
205205
[Theory]
206206
[InlineData("http://httpbin.org/deflate", "\"deflated\": true")]
207207
[InlineData("https://httpbin.org/deflate", "\"deflated\": true")]
208-
[InlineData("http://httpbin.org/gzip", "\"gzipped\": true")]
209-
[InlineData("https://httpbin.org/gzip", "\"gzipped\": true")]
210-
public async Task GetAsync_SetAutomaticDecompression_ContentDecompressed(string uri, string expectedContent)
208+
public async Task GetAsync_SetAutomaticDecompression_ContentDecompressed_Deflate(string uri, string expectedContent)
211209
{
210+
if (IsWinHttpHandler)
211+
{
212+
// WinHttpHandler targets netstandard2.0 and still erroneously uses DeflateStream rather than ZlibStream for deflate.
213+
return;
214+
}
215+
212216
HttpClientHandler handler = CreateHttpClientHandler();
213217
handler.AutomaticDecompression = DecompressionMethods.GZip | DecompressionMethods.Deflate;
214218
using (HttpClient client = CreateHttpClient(handler))

0 commit comments

Comments
 (0)