Add build configuration to generate runtime packs for Android #34192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveisok
reviewed
Mar 27, 2020
steveisok
reviewed
Mar 27, 2020
steveisok
reviewed
Mar 27, 2020
| @@ -187,6 +189,13 @@ | |||
| <TargetsUnix>true</TargetsUnix> | |||
| </PropertyGroup> | |||
| </When> | |||
| <When Condition="$(OutputRid.StartsWith('android'))"> | |||
There was a problem hiding this comment.
@akoeplinger is <TargetsLinux> required here?
There was a problem hiding this comment.
probably not required if it's not used but in general the Targets* seem to follow the RID graph which has Android->Linux->Unix dependency.
steveisok
reviewed
Mar 27, 2020
mdh1418
force-pushed
the
mdhwang/gen_runtime_packs_for_android
branch
3 times, most recently
from
73baade
to
c8b2152
Compare
6 tasks
steveisok
changed the title
mdh1418
force-pushed
the
mdhwang/gen_runtime_packs_for_android
branch
from
cee1712
to
48ae937
Compare
|
Official build PR passes https://dev.azure.com/dnceng/internal/_build/results?buildId=587845&view=results |
dagood
reviewed
Apr 4, 2020
mdh1418
force-pushed
the
mdhwang/gen_runtime_packs_for_android
branch
from
48ae937
to
84923a0
Compare
akoeplinger
reviewed
Apr 6, 2020
mdh1418
force-pushed
the
mdhwang/gen_runtime_packs_for_android
branch
from
84923a0
to
7ec7c75
Compare
dagood
reviewed
Apr 6, 2020
mdh1418
force-pushed
the
mdhwang/gen_runtime_packs_for_android
branch
from
7ec7c75
to
0ffa5d3
Compare
mdh1418
force-pushed
the
mdhwang/gen_runtime_packs_for_android
branch
from
0ffa5d3
to
5ec3cc3
Compare
dagood
approved these changes
Apr 6, 2020
akoeplinger
approved these changes
Apr 6, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for generating Android runtime packs, which is intended to be consumed by the Xamarin Android SDK. It takes after #34050 and when that is merged, this PR will rebase off it.