Add build configuration to generate runtime packs for iOS #34050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
marek-safar
reviewed
Mar 25, 2020
akoeplinger
reviewed
Mar 25, 2020
mdh1418
reviewed
Mar 25, 2020
dagood
reviewed
Mar 25, 2020
src/installer/pkg/projects/netcoreapp/pkg/Microsoft.NETCore.App.Runtime.pkgproj
Outdated
Show resolved
Hide resolved
jaredpar
reviewed
Mar 25, 2020
dagood
reviewed
Mar 25, 2020
This was referenced Mar 25, 2020
mdh1418
reviewed
Mar 26, 2020
mdh1418
reviewed
Mar 27, 2020
mdh1418
reviewed
Mar 27, 2020
safern
reviewed
Mar 27, 2020
safern
reviewed
Mar 27, 2020
jaredpar
reviewed
Mar 31, 2020
| @@ -74,27 +74,27 @@ | |||
| </Target> | |||
|
|
|||
| <Target Name="OverrideRuntimeCoreCLR" | |||
There was a problem hiding this comment.
If we're unifying the Resolve*FilesFromLocalBuild should we unify the OverrideRuntime* target as well?
There was a problem hiding this comment.
I'd prefer doing that in another PR.
safern
reviewed
Mar 31, 2020
added 7 commits
March 31, 2020 17:41
This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.
added 6 commits
March 31, 2020 17:41
…epeat iOS_x64. This was causing the installer leg creation to fail
Added cross and include into the native part of the runtime pack Addressed feedback
dagood
reviewed
Mar 31, 2020
...r/pkg/projects/Microsoft.NETCore.DotNetHostPolicy/Microsoft.NETCore.DotNetHostPolicy.pkgproj
Outdated
Show resolved
Hide resolved
...r/pkg/projects/Microsoft.NETCore.DotNetHostPolicy/Microsoft.NETCore.DotNetHostPolicy.pkgproj
Outdated
Show resolved
Hide resolved
src/installer/pkg/projects/netcoreapp/pkg/Microsoft.NETCore.App.Runtime.pkgproj
Outdated
Show resolved
Hide resolved
dagood
reviewed
Apr 1, 2020
...r/pkg/projects/Microsoft.NETCore.DotNetHostPolicy/Microsoft.NETCore.DotNetHostPolicy.pkgproj
Outdated
Show resolved
Hide resolved
added 2 commits
April 1, 2020 11:11
dagood
approved these changes
Apr 1, 2020
safern
reviewed
Apr 1, 2020
akoeplinger
reviewed
Apr 1, 2020
added 2 commits
April 1, 2020 15:07
…n the official build.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating iOS runtime packs, which is intended to be consumed by the Xamarin iOS SDK.