[mono] Include filename in Invalid image error messages #33117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdh1418
requested review from
alexischr,
CoffeeFlux,
lambdageek,
lewurm,
SamMonoRT,
thaystg and
vargaz
as code owners
mdh1418
changed the title
mdh1418
force-pushed
the
mdhwang/redo_runtime_issue_31650
branch
from
f57ff48
to
4417f50
Compare
mdh1418
changed the title
CoffeeFlux
approved these changes
Mar 9, 2020
mdh1418
force-pushed
the
mdhwang/redo_runtime_issue_31650
branch
from
4417f50
to
6a02051
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31649
Fixes #31650
Testing:
Reproduced Error via
<Runtime Repo Root>/build.sh /p:RuntimeFlavor=monoRemoving
[ActiveIssue("https://github.com/dotnet/runtime/issues/31650", TestRuntimes.Mono)]in AssemblyTests.csRunning
dotnet msbuild /t:RebuildAndTest /p:XunitMethodName=System.Reflection.Tests.AssemblyTests.LoadFile_NoSuchPath_ThrowsFileNotFoundExceptionFixing issue resulted in no errors.