Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Test failed on Helix: System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath #31649

Closed
MaximLipnin opened this issue Feb 3, 2020 · 1 comment · Fixed by #32560, #33117 or mono/mono#19112
Closed

[mono] Test failed on Helix: System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath #31649

MaximLipnin opened this issue Feb 3, 2020 · 1 comment · Fixed by #32560, #33117 or mono/mono#19112
Assignees
@CoffeeFlux @mdh1418
Labels
area-AssemblyLoader-mono runtime-mono specific to the Mono runtime

Comments

@MaximLipnin
Copy link
Contributor

System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath fails on Helix. It will be skipped with ActiveIssue in #2087.

System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(seek: 0) [FAIL]
      Assert.Contains() Failure
      Not found: /tmp/AssemblyTests_fhspupwv.kh4/LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath_358_649ae850
      In value:  Invalid Image
      Stack Trace:
           at System.AssertExtensions.ThrowsContains[BadImageFormatException](Action action, String expectedMessageContent)
           at System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(Int32 seek)
           at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(seek: 5) [FAIL]
      Assert.Contains() Failure
      Not found: /tmp/AssemblyTests_ezgcvxxh.ng3/LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath_358_74e9dbc3
      In value:  Invalid Image
      Stack Trace:
           at System.AssertExtensions.ThrowsContains[BadImageFormatException](Action action, String expectedMessageContent)
           at System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(Int32 seek)
           at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(seek: 50) [FAIL]
      Assert.Contains() Failure
      Not found: /tmp/AssemblyTests_c02d054y.sjs/LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath_358_05123eda
      In value:  Invalid Image
      Stack Trace:
           at System.AssertExtensions.ThrowsContains[BadImageFormatException](Action action, String expectedMessageContent)
           at System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(Int32 seek)
           at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
    System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(seek: 100) [FAIL]
      Assert.Contains() Failure
      Not found: /tmp/AssemblyTests_4egqppii.day/LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath_358_3c0ef32a
      In value:  Invalid Image
      Stack Trace:
           at System.AssertExtensions.ThrowsContains[BadImageFormatException](Action action, String expectedMessageContent)
           at System.Reflection.Tests.AssemblyTests.LoadFile_ValidPEBadIL_ThrowsBadImageFormatExceptionWithPath(Int32 seek)
           at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@maryamariyan maryamariyan added the untriaged New issue has not been triaged by the area owner label Feb 3, 2020
@CoffeeFlux
Copy link
Contributor

See #31650 (comment), failures seem to be for the same reason.

@CoffeeFlux CoffeeFlux removed the untriaged New issue has not been triaged by the area owner label Feb 7, 2020
@CoffeeFlux CoffeeFlux self-assigned this Feb 10, 2020
@mdh1418 mdh1418 mentioned this issue Feb 19, 2020
Merged
@monojenkins monojenkins mentioned this issue Feb 19, 2020
Closed
monojenkins pushed a commit to monojenkins/mono that referenced this issue Mar 2, 2020
@mdh1418
[mono] Include filename in Invalid image error messages
2a9bc12 
Fixes dotnet/runtime#31649
Fixes dotnet/runtime#31650

**Testing**:
Reproduced Error via
`<Runtime Repo Root>/build.sh /p:RuntimeFlavor=mono`
Removing `[ActiveIssue("dotnet/runtime#31650", TestRuntimes.Mono)]` in AssemblyTests.cs
Running `dotnet msbuild /t:RebuildAndTest /p:XunitMethodName=System.Reflection.Tests.AssemblyTests.LoadFile_NoSuchPath_ThrowsFileNotFoundException`

Fixing issue resulted in no errors.
@mdh1418 mdh1418 mentioned this issue Mar 3, 2020
Merged
@monojenkins monojenkins mentioned this issue Mar 3, 2020
Merged
monojenkins pushed a commit to monojenkins/mono that referenced this issue Mar 9, 2020
@mdh1418
[mono] Include filename in Invalid image error messages
1e7adea 
Fixes dotnet/runtime#31649
Fixes dotnet/runtime#31650

**Testing**:
Reproduced Error via
`<Runtime Repo Root>/build.sh /p:RuntimeFlavor=mono`
Removing `[ActiveIssue("dotnet/runtime#31650", TestRuntimes.Mono)]` in AssemblyTests.cs
Running `dotnet msbuild /t:RebuildAndTest /p:XunitMethodName=System.Reflection.Tests.AssemblyTests.LoadFile_NoSuchPath_ThrowsFileNotFoundException`

Fixing issue resulted in no errors.
mdh1418 added a commit to mono/mono that referenced this issue Mar 10, 2020
@monojenkins @mdh1418
[mono] Include filename in Invalid image error messages (#19112)
9ce7798 
Fixes dotnet/runtime#31649
Fixes dotnet/runtime#31650

**Testing**:
Reproduced Error via
`<Runtime Repo Root>/build.sh /p:RuntimeFlavor=mono`
Removing `[ActiveIssue("dotnet/runtime#31650", TestRuntimes.Mono)]` in AssemblyTests.cs
Running `dotnet msbuild /t:RebuildAndTest /p:XunitMethodName=System.Reflection.Tests.AssemblyTests.LoadFile_NoSuchPath_ThrowsFileNotFoundException`

Fixing issue resulted in no errors.

Co-authored-by: mdh1418 <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@CoffeeFlux CoffeeFlux

@mdh1418 mdh1418

Labels
area-AssemblyLoader-mono runtime-mono specific to the Mono runtime
Projects
None yet
Milestone
No milestone
5 participants
@CoffeeFlux @MaximLipnin @maryamariyan @jkotas @mdh1418