[Android] Remove gRPC client tests #121953
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Copilot finished reviewing on behalf of
simonrozsival
November 25, 2025 13:23
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Android gRPC client test infrastructure that was added in PR #73060. The removal is justified as the Android gRPC pipeline has been non-functional for an extended period and no longer serves a useful purpose. The team plans to revisit the need for these tests in the future.
Key Changes
- Removed the complete gRPC test project directory including client tests, server implementation, protobuf definitions, certificates, and Docker configuration
- Removed the dedicated Azure Pipeline configuration for gRPC Android client tests
- Cleaned up all gRPC-related package version references and build properties
Reviewed changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/FunctionalTests/Android/Device_Emulator/gRPC/* | Complete removal of the gRPC test project directory including all test code, protobuf files, certificates, and supporting assets |
| src/libraries/tests.proj | Removed gRPC test project references, exclusions, and cleaned up test execution conditions |
| src/libraries/sendtohelixhelp.proj | Removed Helix correlation payload and pre/post commands for gRPC Docker server setup |
| eng/pipelines/runtime-android-grpc-client-tests.yml | Removed the entire pipeline configuration file for Android gRPC client tests |
| eng/liveBuilds.targets | Removed the GrpcServerDockerImageDir property definition |
| eng/Versions.props | Removed all gRPC-related package version properties (GoogleProtobuf, Grpc.AspNetCore, Grpc.Core, etc.) |
| .config/CredScanSuppressions.json | Removed credential scan suppressions for gRPC test certificates and private keys |
Contributor
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
simonrozsival
removed
the
needs-area-label
vitek-karas
approved these changes
Nov 26, 2025
Member
Author
|
/ba-g Test failures are unrelated (macOS-13 based runner images being deprecated) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes from #73060
The Android gRPC pipeline has been failing for a while and does not currently serve any purpose. We need to revisit the need for this test. For the time being, let's remove this code from the repo.
/cc @tommcdon