Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] gRPC client tests #73060

Merged
merged 36 commits into from
Aug 25, 2022
Merged

Conversation

simonrozsival
Copy link
Member

@simonrozsival simonrozsival commented Jul 29, 2022

To improve gRPC support on mobile platforms, we're adding CI for the Grpc.Client nuget package that runs interop tests on Android emulators. Most of the code in this PR is copied from the https://github.com/grpc/grpc-dotnet repository.

Each test builds and runs a docker container with an gRPC server and runs a functional test on an Android emulator against the server. The test will run periodically and also on demand with /run azp android-grpc-client-tests.

Contributes to #69095

@simonrozsival simonrozsival added the NO-REVIEW Experimental/testing PR, do NOT review it label Jul 29, 2022
@ghost ghost assigned simonrozsival Jul 29, 2022
@ghost
Copy link

ghost commented Jul 29, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This is still WIP.

Author: simonrozsival
Assignees: -
Labels:

NO-REVIEW, area-Infrastructure-mono

Milestone: -

Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few license related comments but looks good otherwise

eng/Versions.props Outdated Show resolved Hide resolved
@simonrozsival simonrozsival merged commit 7a4b0af into main Aug 25, 2022
@akoeplinger akoeplinger deleted the simonrozsival/android-grpc-client-tests branch August 25, 2022 08:35
radical added a commit to radical/runtime that referenced this pull request Aug 29, 2022
PR dotnet#73060 broke uploading of helix test results. This was caused by the
change:

```xml
      <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
```

This is overwriting the existing value of `$(HelixPostCommands)`, which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.

Fix by *appending* to the property.

Thanks to ChadNedzlek for finding the cause!

Fixes dotnet#74699 .
radical added a commit that referenced this pull request Aug 30, 2022
* CI: Fix helix test results reporting

PR #73060 broke uploading of helix test results. This was caused by the
change:

```xml
      <HelixPostCommands>@(HelixPostCommand)</HelixPostCommands>
```

This is overwriting the existing value of `$(HelixPostCommands)`, which
gets set to have the upload script invocation in https://github.com/dotnet/arcade/blob/34dff939b4a91e4693f78a856e0e055c1a3f3fba/src/Microsoft.DotNet.Helix/Sdk/tools/azure-pipelines/AzurePipelines.MonoQueue.targets#L8-L15 at evaluation time.

Fix by *appending* to the property.

Thanks to ChadNedzlek for finding the cause!

Fixes #74699 .

* Disable failing tests, see #74781

Co-authored-by: Alexander Köplinger <[email protected]>
@ghost ghost locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants