Rename ValueType-specific identifiers to reflect dual usage for ValueType and Attribute types #121610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed ValueTypeMethodHashtable to GetFieldMethodHashtable - Renamed _valueTypeMethodHashtable to _getFieldMethodHashtable - Renamed ValueTypeGetFieldHelperMethodOverride to GetFieldHelperMethodOverride - Renamed files: - CompilerTypeSystemContext.ValueTypeMethods.cs → CompilerTypeSystemContext.GetFieldMethodOverrides.cs - ValueTypeGetFieldHelperMethodOverride.cs → GetFieldHelperMethodOverride.cs - ValueTypeGetFieldHelperMethodOverride.Sorting.cs → GetFieldHelperMethodOverride.Sorting.cs - Updated project file references - Updated all usages across the codebase Co-authored-by: MichalStrehovsky <[email protected]>
Copilot
AI
changed the title
[WIP] Rename field method identifiers for clarity
Rename ValueType-specific identifiers to reflect dual usage for ValueType and Attribute types
Nov 14, 2025
Copilot finished work on behalf of
MichalStrehovsky
November 14, 2025 07:48
jkotas
approved these changes
Nov 14, 2025
src/coreclr/tools/Common/TypeSystem/IL/Stubs/GetFieldHelperMethodOverride.cs
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive refactoring to rename ValueType-specific identifiers that are now used for both ValueType and Attribute types. The renaming improves code clarity by reflecting the actual dual usage of these methods and classes.
- Renamed classes from ValueType-specific names to more generic GetField-based names
- Renamed source files to match the new class names
- Updated all usage sites and project file references
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ILCompiler.Compiler.csproj | Updated compile includes for renamed source files |
| ObjectDataInterner.cs | Updated type reference from ValueTypeGetFieldHelperMethodOverride to GetFieldHelperMethodOverride |
| NoMetadataBlockingPolicy.cs | Updated reference to GetFieldHelperMethodOverride.MetadataName |
| EETypeNode.cs | Updated reference to GetFieldHelperMethodOverride.MetadataName in vtable emission logic |
| CompilerTypeSystemContext.GetFieldMethodOverrides.cs | Renamed inner class and field from ValueType-specific names to generic names |
| GetFieldHelperMethodOverride.cs | Renamed class and updated documentation to reflect dual usage |
| GetFieldHelperMethodOverride.Sorting.cs | Updated partial class declaration and type cast |
This was referenced Nov 14, 2025
Open
Member
|
/ba-g timeout in unrelated leg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompilerTypeSystemContext.ValueTypeMethods.csoriginally injected__GetFieldHelperonly into value types but was later extended to also handle attribute types. The naming remained ValueType-specific, creating confusion.Renamed classes:
ValueTypeMethodHashtable→GetFieldMethodHashtableValueTypeGetFieldHelperMethodOverride→GetFieldHelperMethodOverrideRenamed files:
CompilerTypeSystemContext.ValueTypeMethods.cs→CompilerTypeSystemContext.GetFieldMethodOverrides.csValueTypeGetFieldHelperMethodOverride.cs→GetFieldHelperMethodOverride.csValueTypeGetFieldHelperMethodOverride.Sorting.cs→GetFieldHelperMethodOverride.Sorting.csUpdated references:
EETypeNode.cs,NoMetadataBlockingPolicy.cs,ObjectDataInterner.csOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.