[release/10.0] Don't set security descriptor if the mutex is not owned/new #120115
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #120075 to release/10.0
/cc @ericstj @jozkee
Customer Impact
Customer may hit an
UnauthorizedAccessException
when using Performance Counter or EventLog APIs. This happens when another user has created theGlobal\netfxperf.1.0
orGlobal\netfxeventlog.1.0
mutexes. This exception is impossible to predict and will be persistent when hit. The result is the opposite of the intent of the original fix. #110399Fix by only setting the ACL when we create the mutex.
Regression
Regression in .NET 10.0 from #110416
Testing
Manual repro and fix.
Risk
Low, we're just applying a condition to only set the ACL on a Mutex when we are the creator of that mutex.