Skip to content

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Sep 24, 2025

Fixes #116014.
Fixes #110454.

@Copilot Copilot AI review requested due to automatic review settings September 24, 2025 23:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a mutex access control issue by only setting security permissions when the mutex is newly created. The change prevents unnecessary access control modifications on existing mutexes.

  • Only sets mutex access control when createdNew is true
  • Adds conditional check around the existing security configuration code
  • Maintains the same security model but applies it more selectively

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 24, 2025
@jozkee jozkee requested a review from ericstj September 24, 2025 23:04
@jkotas jkotas added area-System.Diagnostics.EventLog and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 24, 2025
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter
See info in area-owners.md if you want to be subscribed.

@jozkee jozkee changed the title Don't set access control if the mutex is not initially owned Don't set security descriptor if the mutex is not owned/new Sep 25, 2025
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed - you've done manual testing involving multiple users to ensure this is fixed. I imagine we cannot cover this easily in CI.

@ericstj ericstj merged commit bf486c8 into dotnet:main Sep 25, 2025
96 checks passed
@ericstj
Copy link
Member

ericstj commented Sep 25, 2025

/backport to release/10.0

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment