-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Don't set security descriptor if the mutex is not owned/new #120075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a mutex access control issue by only setting security permissions when the mutex is newly created. The change prevents unnecessary access control modifications on existing mutexes.
- Only sets mutex access control when
createdNew
is true - Adds conditional check around the existing security configuration code
- Maintains the same security model but applies it more selectively
Tagging subscribers to this area: @dotnet/area-system-diagnostics-performancecounter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed - you've done manual testing involving multiple users to ensure this is fixed. I imagine we cannot cover this easily in CI.
/backport to release/10.0 |
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18021213909 |
Fixes #116014.
Fixes #110454.