[release/10.0] JIT: Add missing containment check for indirect calls #119812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
kg
approved these changes
Sep 17, 2025
|
/ba-g All issues are known, but build-analysis is not switching to green |
JulieLeeMSFT
approved these changes
Sep 19, 2025
JulieLeeMSFT
added
the
area-CodeGen-coreclr
Build analysis doesn’t turn green on release branch. |
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
CC @jeffschwMSFT. |
agocke
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119806 to release/10.0
/cc @jakobbotsch
Customer Impact
The JIT is missing a safety check for whether indirect calls can be optimized to perform the indirection as part of the call instruction on x64.
Regression
New IR produced by runtime async exposes calls that causes the backend to trip over this.
Testing
Verified manually on a specific function in our own libraries tests that hit the case. Test case not introduced since existing tests already cover it when runtime async is enabled.
Risk
Low. The safety check comes with no diffs over our SPMI collections and should in the worst case just result in a load performed slightly earlier.