Skip to content

JIT: Add missing containment check for indirect calls #119806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 17, 2025
Merged

JIT: Add missing containment check for indirect calls #119806

merged 1 commit into from
Sep 17, 2025
+1 −1

Conversation

jakobbotsch
Copy link
Member

Fix #119623

@github-actions github-actions bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 17, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jakobbotsch jakobbotsch marked this pull request as ready for review September 17, 2025 15:06
@Copilot Copilot AI review requested due to automatic review settings September 17, 2025 15:06
Copilot
Copilot AI reviewed Sep 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a missing containment check for indirect calls in the JIT compiler. The change adds proper safety validation before containing memory operands in indirect call expressions.

  • Adds a safety check (IsSafeToContainMem) to ensure memory operands can be safely contained for indirect calls

@jakobbotsch
Copy link
Member Author

cc @dotnet/jit-contrib

No diffs. Some minor TP regressions.

@jakobbotsch jakobbotsch mentioned this pull request Sep 17, 2025
Closed
@jakobbotsch jakobbotsch merged commit 7002eeb into dotnet:main Sep 17, 2025
113 checks passed
@jakobbotsch
Copy link
Member Author

/backport to release/10.0

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17802381778

@github-actions github-actions bot mentioned this pull request Sep 17, 2025
Merged
4 tasks
This was referenced Sep 18, 2025
Merged
Draft
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@EgorBo EgorBo EgorBo approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

@jakobbotsch jakobbotsch

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RuntimeAsync] A few asserts like "Assertion failed 'isSafeToContainMem'" in Libraries tests when runtime async is enabled

3 participants

@jakobbotsch @EgorBo @tannergooding