Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 8, 2025

Backport of #119393 to release/10.0

/cc @max-charlamb

Customer Impact

  • Customer reported
  • Found internally

Found while working on #119324. Since the GetGCInterestingInfoData DAC API marshalled the dac_gc_heap incorrectly, the SOS command !dumpgcdata gives incorrect results on server builds.

Regression

  • Yes
  • No

Unclear if this ever worked, or if other logic changed causing this to fail at some point.

Testing

Verfied by new test in the diagnostic repo.
See new test: dotnet/diagnostics#5562
See successful run with new test: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1140803&view=results

Risk

Low. This change does not modify the runtime; it only modifies the DAC build.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copy link
Member

@JulieLeeMSFT JulieLeeMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please check the pipeline results.

@JulieLeeMSFT JulieLeeMSFT added the Servicing-approved Approved for servicing release label Sep 8, 2025
@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Sep 8, 2025
@jeffschwMSFT jeffschwMSFT merged commit 9680646 into release/10.0 Sep 11, 2025
102 of 105 checks passed
@jkotas jkotas deleted the backport/pr-119393-to-release/10.0 branch September 22, 2025 23:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants