- 
                Notifications
    
You must be signed in to change notification settings  - Fork 382
 
[SOS/DAC] Add tests for DAC GC bugs #5562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           I believe we need to have a scheme to disable this test for versions of the runtime older than .NET 11 (unless of course you intend to fix this in downlevel versions), but this looks generally ok to me.  | 
    
          
 diagnostics/src/SOS/SOS.UnitTests/SOS.cs Line 206 in a853665 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Comments inline where I'm hoping we can simplify the config pattern.
| InitializeHandleRoots(); | ||
| 
               | 
          ||
| int i = _dependentHandles.BinarySearch((source, target)); | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this bug while working on the tests. In some cases, this is not initialized before referencing.
internal_root_arrayruntime#119396