Skip to content

Add test coverage for issue #99193 #119384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2025
Merged

Add test coverage for issue #99193 #119384

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ab5c53
Add test coverage for issue #99193
StephenMolloy Sep 5, 2025
e821100
Merge branch 'main' into 99193_Add-Test
StephenMolloy Sep 22, 2025
ee684e9
Make two-digit year boundary test more resilient to changes in DateTi…
StephenMolloy Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...raries/System.ServiceModel.Syndication/tests/System.ServiceModel.Syndication.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<Compile Include="System\ServiceModel\Syndication\SyndicationFeedFormatterTests.cs" />
<Compile Include="System\ServiceModel\Syndication\SyndicationItemFormatterTests.cs" />
<Compile Include="System\ServiceModel\Syndication\SyndicationFeedTests.cs" />
<Compile Include="System\ServiceModel\Syndication\Rfc822DateParsingTests.cs" />
<Compile Include="Utils\CompareHelper.cs" />
<Compile Include="Utils\ThrowingXmlReader.cs" />
<Compile Include="Utils\XmlDiff.cs" />
Expand Down
60 changes: 60 additions & 0 deletions ....ServiceModel.Syndication/tests/System/ServiceModel/Syndication/Rfc822DateParsingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System.IO;
using System.Xml;
using Xunit;
using System.Globalization;

namespace System.ServiceModel.Syndication.Tests
{
public class Rfc822DateParsingTests
{
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] // NetFx requires double digit dates and four digit years
[Theory]
[InlineData("Mon, 2 Jun 2003 09:39:21 GMT", 2003, 6, 2, 9, 39, 21)]
[InlineData("2 Jun 2003 09:39:21 GMT", 2003, 6, 2, 9, 39, 21)]
[InlineData("02 Jun 03 09:39:21 GMT", 2003, 6, 2, 9, 39, 21)]
[InlineData("Mon, 2 Jun 03 09:39:21 GMT", 2003, 6, 2, 9, 39, 21)]
[InlineData("2 Jun 03 09:39 GMT", 2003, 6, 2, 9, 39, 0)]
[InlineData("02 Jun 03 09:39 GMT", 2003, 6, 2, 9, 39, 0)]
[InlineData("Mon, 2 Jun 03 09:39 GMT", 2003, 6, 2, 9, 39, 0)]
[InlineData("Mon, 02 Jun 03 09:39 GMT", 2003, 6, 2, 9, 39, 0)]
// As of .Net 8.0, CultureInfo.CurrentCulture.DateTimeFormat.Calendar.TwoDigitYearMax is 2049 for invariant and en-US cultures
[InlineData("2 Jun 50 09:39 GMT", 1950, 6, 2, 9, 39, 0)]
[InlineData("2 Jun 49 09:39 GMT", 2049, 6, 2, 9, 39, 0)]
public void Rss20ItemFormatter_Read_SingleDigitDay_And_TwoDigitYear(string pubDate, int year, int month, int day, int hour, int minute, int second)
{
string xml = $"<item><pubDate>{pubDate}</pubDate></item>";
using var stringReader = new StringReader(xml);
using var reader = XmlReader.Create(stringReader);
var formatter = new Rss20ItemFormatter();
formatter.ReadFrom(reader);
DateTimeOffset expected = new DateTimeOffset(year, month, day, hour, minute, second, TimeSpan.Zero);
Assert.Equal(expected, formatter.Item.PublishDate);
}

[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework)] // NetFx requires double digit dates and four digit years
[Theory]
[InlineData("Mon, 2 Jun 2003 09:39:21 +0000", 2003, 6, 2, 9, 39, 21)]
[InlineData("Mon, 2 Jun 2003 09:39:21 -0000", 2003, 6, 2, 9, 39, 21)]
[InlineData("Mon, 2 Jun 2003 09:39:21 UT", 2003, 6, 2, 9, 39, 21)]
[InlineData("Mon, 02 Jun 03 09:39:21 +0000", 2003, 6, 2, 9, 39, 21)]
[InlineData("Mon, 02 Jun 03 09:39:21 -0000", 2003, 6, 2, 9, 39, 21)]
[InlineData("Mon, 02 Jun 03 09:39:21 UT", 2003, 6, 2, 9, 39, 21)]
// As of .Net 8.0, CultureInfo.CurrentCulture.DateTimeFormat.Calendar.TwoDigitYearMax is 2049 for invariant and en-US cultures
[InlineData("02 Jun 50 09:39:21 +0000", 1950, 6, 2, 9, 39, 21)]
[InlineData("02 Jun 50 09:39:21 -0000", 1950, 6, 2, 9, 39, 21)]
[InlineData("02 Jun 49 09:39:21 UT", 2049, 6, 2, 9, 39, 21)]
public void Rss20ItemFormatter_Read_SingleDigitDay_NormalizedTimeZones(string pubDate, int year, int month, int day, int hour, int minute, int second)
{
string xml = $"<item><pubDate>{pubDate}</pubDate></item>";
using var stringReader = new StringReader(xml);
using var reader = XmlReader.Create(stringReader);
var formatter = new Rss20ItemFormatter();
formatter.ReadFrom(reader);
DateTimeOffset expectedUtc = new DateTimeOffset(year, month, day, hour, minute, second, TimeSpan.Zero);
Assert.Equal(expectedUtc, formatter.Item.PublishDate);
}
}
}
Loading