Add test coverage for issue #99193 #119384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for issue #99193 related to RFC 822 date parsing in System.ServiceModel.Syndication. The tests specifically focus on handling single-digit days and two-digit years in RSS 2.0 item formatters, which appears to be a bug that will be fixed in a separate PR (#99194).
Key Changes
- Added comprehensive test coverage for RFC 822 date parsing edge cases
- Tests cover single-digit days, two-digit years, and various timezone formats
- Tests are specifically designed to skip on .NET Framework due to different parsing requirements
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.ServiceModel.Syndication/tests/System/ServiceModel/Syndication/Rfc822DateParsingTests.cs | New test file containing comprehensive RFC 822 date parsing tests for edge cases |
| src/libraries/System.ServiceModel.Syndication/tests/System.ServiceModel.Syndication.Tests.csproj | Added the new test file to the project compilation list |
github-actions
bot
added
the
needs-area-label
StephenMolloy
added
area-System.ServiceModel.Syndication
and removed
needs-area-label
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17996491135 |
…meFormat.Calendar.TwoDigitYearMax
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for issue #99193
Will fail if merged before fix (PR #99194)