-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Misc. illumous build fixes (prereq. for #105403) #117023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm keeping the commits in this PR separately for now as that's easier for my local work. |
Repo maintainers can squash on merge (GitHub merge button has that option). |
Needs approvers. @am11 ? |
37200d5 is being scheduled for building and testingGIT: |
OK, then I'm not seeing how to relate what's shown there to my changes. Suggestions? |
I have no idea why your browser is not showing you the error seen in the screenshot. But I am still seeing the same |
OK, thanks. How do I relate that to anything in this PR?
I could also use help on how to run these tests:
src/tests/JIT/superpmi/
…On Tue, Jul 8, 2025 at 8:29 AM Adeel Mujahid ***@***.***> wrote:
*am11* left a comment (dotnet/runtime#117023)
<#117023 (comment)>
I have no idea why your browser is not showing you the error seen in the
screenshot. But I am still seeing the same cmdLine:/root/helix/work/workitem/e/JIT/JIT_others/../superpmi/superpmicollect/superpmicollect.sh
Timed Out (timeout in milliseconds: 600000 from variable __TestTimeout
pretty clearly on Build Analysis page. This is a "new" error related to
your change in superpmi code, that will need to be fixed. Other errors are
unrelated you can ignore.
—
Reply to this email directly, view it on GitHub
<#117023 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG33HEAAGCOGD2FOD7JAVD3HO2Q3AVCNFSM6AAAAACADTDMO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTANBYG42TGMZSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This PR is changing superpmi code for other platforms to support a new platform (illumos). Those tests are not failing on main. So I guess it's pretty simple deduction something in this change broke it. You can revert the superpmi change in a commit, wait for CI to complete (including Pri0 tests), then reapply the change to confirm Pri0 superpmi tests are indeed broken by dirent change.. As mentioned above #117023 (comment), there is a prior art how we supported dirent related calls for illumos in other places without breaking other platforms. You can piggyback those implementations or try to avoid changing it for other platforms (
Refer to |
RISC-V Release-CLR-VF2: 9081 / 9111 (99.67%)
report.xml, report.md, failures.xml, testclr_details.tar.zst RISC-V Release-FX-QEMU: 284020 / 285105 (99.62%)
report.xml, report.md, failures.xml, testclr_details.tar.zst Build information and commandsGIT: |
Trimmed down set to help identify which thing is causing problems. |
If the CI is green on this trimmed down set, I will be happy to merge it so that you can focus on the rest in a separate PR. |
The only unexpected CI failure I see now is a timeout sending to Helix: runtime / Build / browser-wasm linux Release WasmBuildTests Am I interpreting that correctly? |
Are the remaining CI complaints here expected? To me they look similar to what I see with a PR containing only a trivial change (eg. #117478 ) |
dotnet/runtime/src/native/minipal/debugger.c:127:5: error: implicit declaration of function 'snprintf' [-Werror=implicit-function-declaration] 127 | snprintf(statusFilename, sizeof(statusFilename), "/proc/%d/status", getpid()); | ^~~~~~~~
src/native/minipal/thread.h:73:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] 73 | tid = (size_t)(void*)pthread_self(); | ^~~~~~~~~~~~~~~~~~~~~
src/native/libs/System.Native/pal_mount.c:164:38: error: 'struct statvfs' has no member named 'f_type' 164 | *formatType = (int64_t)(stats.f_type); | ^
/home/gwr/dotnet/runtime/src/coreclr/pal/src/thread/thread.cpp:1367:5: error: 'cid' was not declared in this scope 1367 | cid = CLOCK_THREAD_CPUTIME_ID; | ^~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Fix compile error at minipal/debugger.c:127
dotnet/runtime/src/native/minipal/debugger.c:127:5: error: implicit declaration of function 'snprintf' [-Werror=implicit-function-declaration]
127 | snprintf(statusFilename, sizeof(statusFilename), "/proc/%d/status", getpid());
| ^~~~~~~~
Fix compile error in minipal/thread.h
src/native/minipal/thread.h:73:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
73 | tid = (size_t)(void*)pthread_self();
| ^~~~~~~~~~~~~~~~~~~~~
Fix compile error in native/libs/System.Native/pal_mount.c
src/native/libs/System.Native/pal_mount.c:164:38: error: 'struct statvfs' has no member named 'f_type'
164 | *formatType = (int64_t)(stats.f_type);
| ^
Fix compile error in coreclr/pal/src/thread/thread.cpp
/home/gwr/dotnet/runtime/src/coreclr/pal/src/thread/thread.cpp:1367:5: error: 'cid' was not declared in this scope
1367 | cid = CLOCK_THREAD_CPUTIME_ID;
| ^~~
Other changes pulled out into separate PRs:
#117462
#117463
#117464