Skip to content

JIT: Skip extra SPMI queries when we don't know the exact type #115637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025
Merged

JIT: Skip extra SPMI queries when we don't know the exact type #115637

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9936,9 +9936,10 @@ void Compiler::impImportBlockCode(BasicBlock* block)
impPushOnStack(gtNewLclvNode(lclNum, TYP_REF), tiRetVal);

#ifdef DEBUG
// Under SPMI, look up info we might ask for if we stack allocate this array
// Under SPMI, look up info we might ask for if we stack allocate this array,
// but only if we know the precise type
//
if (JitConfig.EnableExtraSuperPmiQueries())
if (JitConfig.EnableExtraSuperPmiQueries() && !eeIsSharedInst(resolvedToken.hClass))
Copy link

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider expanding the comment to clarify what qualifies as a 'precise type' and what constitutes a shared instance, to improve maintainability and clarity.

Copilot uses AI. Check for mistakes.
{
void* pEmbedClsHnd;
info.compCompHnd->embedClassHandle(resolvedToken.hClass, &pEmbedClsHnd);
Expand Down
Loading