JIT: Skip extra SPMI queries when we don't know the exact type #115637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the SPMI query logic by guarding extra queries with a check for a precise type to avoid unnecessary work.
- Added an extra condition in the SPMI query on stack allocated arrays.
- Updated comments to reflect the new behavior regarding precise type checks.
| // but only if we know the precise type | ||
| // | ||
| if (JitConfig.EnableExtraSuperPmiQueries()) | ||
| if (JitConfig.EnableExtraSuperPmiQueries() && !eeIsSharedInst(resolvedToken.hClass)) |
There was a problem hiding this comment.
Consider expanding the comment to clarify what qualifies as a 'precise type' and what constitutes a shared instance, to improve maintainability and clarity.
github-actions
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
cc @dotnet/jit-contrib, @AndyAyersMS PTAL. I think this is the right guard -- collecting NativeAOT smoke tests locally doesn't hit asserts anymore -- but let me know if I need something broader. Thanks! |
AndyAyersMS
approved these changes
May 16, 2025
Open
3 tasks
|
/ba-g NativeAOT build timeout, and dead-lettered test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114934.