Skip to content

JIT: Skip rarely-run block expansion during flow opts when we have profile data #114311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

JIT: Skip rarely-run block expansion during flow opts when we have profile data #114311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/coreclr/jit/optimizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,11 +2379,11 @@ PhaseStatus Compiler::optOptimizeFlow()

bool modified = fgUpdateFlowGraph(/* doTailDuplication */ true);

// Skipping fgExpandRarelyRunBlocks when we have PGO data incurs diffs if the profile is inconsistent,
// as it will propagate missing profile weights throughout the flowgraph.
// Running profile synthesis beforehand should get rid of these diffs.
// TODO: Always rely on profile synthesis to identify cold blocks.
modified |= fgExpandRarelyRunBlocks();
if (!fgIsUsingProfileWeights())
{
modified |= fgExpandRarelyRunBlocks();
}

// Run branch optimizations for non-handler blocks.
assert(!fgFuncletsCreated);
Expand Down
Loading