Skip to content

Conversation

@amanasifkhalid
Copy link
Contributor

Follow-up to #113896. Since we now run profile repair before most of the profile-sensitive post-morph opts, fgExpandRarelyRunBlocks isn't very useful for PGO scenarios.

@Copilot Copilot AI review requested due to automatic review settings April 6, 2025 20:41
@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/coreclr/jit/optimizer.cpp:2383

  • Ensure unit tests cover both paths of this condition (when profile weights are in use and when they are not) to validate that the rarely-run block expansion behaves as expected.
if (!fgIsUsingProfileWeights())

@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@amanasifkhalid
Copy link
Contributor Author

Small diffs from fgOptimizeBranch considering more blocks during post-morph flow opts, now that fewer blocks are marked rarely-run.

@amanasifkhalid amanasifkhalid merged commit 6eabb60 into dotnet:main Apr 8, 2025
112 checks passed
@amanasifkhalid amanasifkhalid deleted the skip-fgExpandRarelyRunBlocks branch April 8, 2025 15:19
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants