JIT: Enable containment for BMI2 shift and rotate instructions #111778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
saucecontrol
changed the title
|
@saucecontrol Please merge up to main. |
|
@saucecontrol Sorry, there's a new merge conflict. Can you merge and resolve it? |
|
Done, and took care of #113237 (review) |
BruceForstall
approved these changes
Mar 18, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67314
Fixes #81522
This enables containment for the BMI2 shift and rotate instructions, and it enables those instructions on x86.
Diffs look good. There's a size regression on x86, since sarx/shlx/shrx are larger, but they are also much faster than the legacy instructions that take shift amount in
cl.