-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix linux build image in eng/pipelines/libraries/stress/http.yml #111664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
Hi, I don't know, we are using the same image for SslStress, with pretty much the same setup (we also use this envvar substitution in ssl stress compose file). Do we know the docker version on the image? |
/azp run runtime-libraries stress-ssl |
Azure Pipelines successfully started running 1 pipeline(s). |
I found some differences in the way docker-compose.yml was structured compared to SslStress, pushed the changes. |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
@antonfirsov @rzikm looks like this will need a bit more attention than the quick fix I thought, would you mind taking over the PR? |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
thanks. something seems to be up with the http 3.0 stress test, if you click "View raw log" on AzDO you see this message from AddressSanitizer infinitely repeated:
|
That's weird, I can't reproduce this locally, maybe we should disable address sanitizer for now |
/azp run runtime-libraries stress-http |
Azure Pipelines successfully started running 1 pipeline(s). |
this might be related since we're now using Ubuntu 22.04 hosts: actions/runner-images#9524 |
Looks like it's green now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13904193229 |
@antonfirsov backporting to "release/9.0-staging" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Fix linux build image in eng/pipelines/libraries/stress/http.yml
Using index info to reconstruct a base tree...
M eng/pipelines/libraries/stress/http.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/libraries/stress/http.yml
Applying: Align docker-compose.yml with the one from SslStress
Using index info to reconstruct a base tree...
M src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml
Falling back to patching base and 3-way merge...
Auto-merging src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml
CONFLICT (content): Merge conflict in src/libraries/System.Net.Http/tests/StressTests/HttpStress/docker-compose.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 Align docker-compose.yml with the one from SslStress
Error: The process '/usr/bin/git' failed with exit code 128 Please backport manually! |
@rzikm This fixes the disk space issue. It still fails to build with this error in the "Build HttpStress" step, do you have an idea: