Skip to content

Fix IDE0004 for object comparison #110206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 12, 2025
Merged

Fix IDE0004 for object comparison #110206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c3fc7b6
Fix `IDE0004` for object comparison
xtqqczze Nov 26, 2024
04d3df5
revert `src/libraries/System.Private.CoreLib/src/System/RuntimeType.cs`
xtqqczze Nov 26, 2024
ae2598b
Merge branch 'main' into IDE0004-obj-comp
xtqqczze Dec 10, 2024
428a6a1
Merge branch 'main' into IDE0004-obj-comp
xtqqczze Dec 19, 2024
b133192
Merge branch 'main' into IDE0004-obj-comp
xtqqczze Dec 22, 2024
050b40c
Merge branch 'main' into IDE0004-obj-comp
xtqqczze Jan 11, 2025
3e47497
Merge branch 'main' into IDE0004-obj-comp
xtqqczze Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Reflection/CustomAttributeData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ public override string ToString()

return vsb.ToString();
}
public override int GetHashCode() => base.GetHashCode();
public override bool Equals(object? obj) => obj == (object)this;
#endregion

#region Public Members
Expand Down
8 changes: 4 additions & 4 deletions src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ public bool EndsWith(string value, StringComparison comparisonType)
{
ArgumentNullException.ThrowIfNull(value);

if ((object)this == (object)value)
if (ReferenceEquals(this, value))
{
CheckStringComparison(comparisonType);
return true;
Expand Down Expand Up @@ -580,7 +580,7 @@ public bool EndsWith(string value, bool ignoreCase, CultureInfo? culture)
{
ArgumentNullException.ThrowIfNull(value);

if ((object)this == (object)value)
if (ReferenceEquals(this, value))
{
return true;
}
Expand Down Expand Up @@ -1108,7 +1108,7 @@ public bool StartsWith(string value, StringComparison comparisonType)
{
ArgumentNullException.ThrowIfNull(value);

if ((object)this == (object)value)
if (ReferenceEquals(this, value))
{
CheckStringComparison(comparisonType);
return true;
Expand Down Expand Up @@ -1158,7 +1158,7 @@ public bool StartsWith(string value, bool ignoreCase, CultureInfo? culture)
{
ArgumentNullException.ThrowIfNull(value);

if ((object)this == (object)value)
if (ReferenceEquals(this, value))
{
return true;
}
Expand Down