Skip to content

Fix IDE0004 for object comparison #110206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 12, 2025
Merged

Fix IDE0004 for object comparison #110206

merged 7 commits into from
Mar 12, 2025

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Nov 26, 2024 •
edited
Loading

no asm diffs expected

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 26, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Nov 26, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 27, 2024
Closed
@jeffhandley jeffhandley added area-Meta and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 19, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Dec 19, 2024

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Dec 20, 2024
Open
@xtqqczze
Copy link
Contributor Author

xtqqczze commented Dec 22, 2024

@MihuBot

@MihuBot MihuBot mentioned this pull request Dec 22, 2024
Open
This was referenced Dec 22, 2024
Open
Open
@EgorBo
Copy link
Member

EgorBo commented Mar 4, 2025

@stephentoub @tannergooding should we accept it?

@tannergooding
Copy link
Member

tannergooding commented Mar 4, 2025

No particular preference here. I do think that ReferenceEquals is more explicit about intent than casting to object, so I think that's an improvement.

@stephentoub stephentoub merged commit 64388a0 into dotnet:main Mar 12, 2025
140 checks passed
@xtqqczze xtqqczze deleted the IDE0004-obj-comp branch March 12, 2025 22:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

No one assigned

Labels

area-Meta community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @EgorBo @tannergooding @stephentoub @jeffhandley