[Swift interop] Add inline array struct lowering tests #107859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkurdek
added
area-Interop-coreclr
os-ios
jkurdek
requested review from
jakobbotsch,
jkoritzinsky,
kotlarmilos and
matouskozak
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
matouskozak
approved these changes
Sep 20, 2024
Member
matouskozak
left a comment
matouskozak
left a comment
There was a problem hiding this comment.
Minor comment about the naming but overall looks good to me! Thank you for catching this.
kotlarmilos
approved these changes
Sep 27, 2024
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
jkurdek
added a commit
to jkurdek/runtime
that referenced
this pull request
Oct 2, 2024
* [swift interop] Add inline array tests * Rename test suite
4 tasks
sirntar
pushed a commit
to sirntar/runtime
that referenced
this pull request
Oct 3, 2024
* [swift interop] Add inline array tests * Rename test suite
jeffschwMSFT
added a commit
that referenced
this pull request
Oct 3, 2024
* Fix lowering support for inline arrays (#107744) * [Swift interop] Add inline array struct lowering tests (#107859) * [swift interop] Add inline array tests * Rename test suite --------- Co-authored-by: Jeff Schwartz <[email protected]>
lambdageek
pushed a commit
to lambdageek/runtime
that referenced
this pull request
Oct 3, 2024
* [swift interop] Add inline array tests * Rename test suite
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both CoreCLR and Mono implement swift struct lowering algorithm for structs with
InlineArray. This PR adds missing tests.Fixes #107857