Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

Open
wants to merge 66 commits into
base: main
Choose a base branch
from
Open

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

wants to merge 66 commits into from

Commits on Aug 28, 2024

  1. Log ShuffleEntries from GenerateShuffleArray

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    70cf57f View commit details
    Browse the repository at this point in the history

  2. Add failing tests for passing FP structs through shuffling thunks

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1377172 View commit details
    Browse the repository at this point in the history

  3. Report proper ShuffleEntries for lowered FP structs

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1cec66b View commit details
    Browse the repository at this point in the history

  4. Implement shuffling thunk generation in tighter, more focused loops i… 

    …nstead of an omnibus loop handling ShuffleEntries
    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    329321b View commit details
    Browse the repository at this point in the history

  5. Generate ShuffleEntries for delowered arguments

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9a50786 View commit details
    Browse the repository at this point in the history

  6. Better ShuffleEntry mask names, one more bit for field offset

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    87c8397 View commit details
    Browse the repository at this point in the history

  7. Fix FpStruct for dst arg loc

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    8b3b470 View commit details
    Browse the repository at this point in the history

  8. Fold ShuffleEntry generation code for lowering and delowering FpStructs

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1a14067 View commit details
    Browse the repository at this point in the history

  9. ShuffleEntry mask doc update

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6fa6d18 View commit details
    Browse the repository at this point in the history

  10. Implement forward shuffling of floating registers and delowering of F… 

    …pStructs. EmptyStructs test passes except for ShufflingThunk_FloatEmptyShort_DoubleFloatNestedEmpty_RiscV
    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    114583a View commit details
    Browse the repository at this point in the history

  11. Fix shuffling of integer registers for member functions

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    331d77e View commit details
    Browse the repository at this point in the history

  12. The delowered argument can also be put in the first stack slot

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    1d96d11 View commit details
    Browse the repository at this point in the history

  13. Stask shuffling after delowered argument doesn't start with 0. Fixes … 

    …Regressions/coreclr/GitHub_16833/Test16833
    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    30edbc5 View commit details
    Browse the repository at this point in the history

  14. Code cleanup, fewer indents

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a445275 View commit details
    Browse the repository at this point in the history

  15. Support second lowering

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    bec2d89 View commit details
    Browse the repository at this point in the history

  16. Remove unused CondCode

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    83dee89 View commit details
    Browse the repository at this point in the history

  17. Handle stack slot shuffling to the right

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    b1466a0 View commit details
    Browse the repository at this point in the history

  18. Add some stack slots to shuffle in the growing stack test case

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    6a7d2ce View commit details
    Browse the repository at this point in the history

  19. Fix Equals signature on test structs

    @tomeksowi
    tomeksowi committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    bb28b72 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Remodel the shuffling with calling convention transfer to recognize t… 

    …he key points first, which simplifies code and solves some corner cases e.g. where we can't assume struct stack size by checking the size + offset of the last field
    @tomeksowi
    tomeksowi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    dbb5338 View commit details
    Browse the repository at this point in the history

  2. Use helper functions in EmitComputedInstantiatingMethodStub

    @tomeksowi
    tomeksowi committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    68e0c36 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Implement stack growing in shuffling thunk

    @tomeksowi
    tomeksowi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    015aed0 View commit details
    Browse the repository at this point in the history

  2. Use signed immediate in EmitSubImm to be consistent with EmitAddImm

    @tomeksowi
    tomeksowi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3dcc74c View commit details
    Browse the repository at this point in the history

  3. Use ABI register names in logs

    @tomeksowi
    tomeksowi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    afdec48 View commit details
    Browse the repository at this point in the history

  4. Remove LoadRegPair because it's not used

    @tomeksowi
    tomeksowi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    84bffa4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Add logging for slli and lui

    @tomeksowi
    tomeksowi committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    de61b96 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Remove stack growing from hand-emitted shuffle thunks

    @tomeksowi
    tomeksowi committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    750122a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Minor FloatFloatEmpty test cleanup

    @tomeksowi
    tomeksowi committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    d12ca52 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Implement IL shuffling thunks for cases where the stack is growing

    @tomeksowi
    tomeksowi committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    461f0c3 View commit details
    Browse the repository at this point in the history

  2. Test stack walking in frames laid by the IL shuffle thunk

    @tomeksowi
    tomeksowi committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    fea44e3 View commit details
    Browse the repository at this point in the history

  3. Add assert and comment in CreateILDelegateShuffleThunk

    @tomeksowi
    tomeksowi committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    64a4a62 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fp-structs-shuffling-thunks

    @tomeksowi
    tomeksowi committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    1c7b0b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Fix release build

    @tomeksowi
    tomeksowi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    7f81c07 View commit details
    Browse the repository at this point in the history

  2. Fixes for static delegates from member methods

    @tomeksowi
    tomeksowi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    4b1b31a View commit details
    Browse the repository at this point in the history

  3. Fix log and comment

    @tomeksowi
    tomeksowi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2edf53d View commit details
    Browse the repository at this point in the history

  4. Remove EmitJumpAndLinkRegister because it's no longer used

    @tomeksowi
    tomeksowi committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    74dcd7c View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Use TransferredField.reg in delowering (cosmetic fix to restart CI)

    @tomeksowi
    tomeksowi committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    c5f72c6 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'main' into fp-structs-shuffling-thunks

    @tomeksowi
    tomeksowi committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5ed7466 View commit details
    Browse the repository at this point in the history

  2. New stub type for delegate shuffle thunk so it doesn't go in multidel… 

    …egate code paths
    @tomeksowi
    tomeksowi committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3bbc188 View commit details
    Browse the repository at this point in the history

  3. Make Test_ShufflingThunk_MemberGrowsStack_RiscV harder by returning v… 

    …ia buffer
    @tomeksowi
    tomeksowi committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    268a28b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Explain lowering

    @tomeksowi
    tomeksowi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ccd4aae View commit details
    Browse the repository at this point in the history

  2. Fold 12-bit sign extension branch in EmitMovConstant

    @tomeksowi
    tomeksowi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    1c18c46 View commit details
    Browse the repository at this point in the history

  3. Harden Test_ShufflingThunk_PackedEmptyUintEmptyFloat_PackedEmptyDoubl… 

    …e to cover interleaving FP and int arguments
    @tomeksowi
    tomeksowi committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    6c7e29f View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Merge branch 'main' into fp-structs-shuffling-thunks 

    Conflicts:
	src/coreclr/vm/dllimport.h
    @tomeksowi
    tomeksowi committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    12eb8ba View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Handle shuffles between calling conventions in IL stubs

    @tomeksowi
    tomeksowi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    f4620c4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fp-structs-shuffling-thunks

    @tomeksowi
    tomeksowi committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    2e20dfa View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Update comments

    @tomeksowi
    tomeksowi committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c2acecb View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Don't use NewStub for IL stubs

    @tomeksowi
    tomeksowi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    5773596 View commit details
    Browse the repository at this point in the history

  2. Fold some more duplicated code into SetupShuffleThunk

    @tomeksowi
    tomeksowi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    cdd04ec View commit details
    Browse the repository at this point in the history

  3. Clean up unnecessary diffs

    @tomeksowi
    tomeksowi committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    ae18a27 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'main' into fp-structs-shuffling-thunks

    @tomeksowi
    tomeksowi committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    c4025b7 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. IL shuffle thunk takes target function address from delegate object. … 

    …Cache the generated thunk on DelegateEEClass
    @tomeksowi
    tomeksowi committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    a008f20 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Build target signature based on delegate signature instead of just us… 

    …ing the signature from target method to retain type context
    @tomeksowi
    tomeksowi committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    2900dfb View commit details
    Browse the repository at this point in the history

  2. Test calling instance and static methods via the same delegate type

    @tomeksowi
    tomeksowi committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    fe5d775 View commit details
    Browse the repository at this point in the history

  3. Simplify shuffle thunk caching on DelegateEEClass

    @tomeksowi
    tomeksowi committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    9321b07 View commit details
    Browse the repository at this point in the history

  4. Clean up CreateILDelegateShuffleThunk

    @tomeksowi
    tomeksowi committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    5e1455c View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Delete Windows X86 stack size check

    @tomeksowi
    tomeksowi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ec1c57a View commit details
    Browse the repository at this point in the history

  2. Remove #ifdefs around ILSTUB_DELEGATE_SHUFFLE_THUNK, fix typo in GetS… 

    …tubMethodName
    @tomeksowi
    tomeksowi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    27c005f View commit details
    Browse the repository at this point in the history

  3. Fix DecRef'ing path when the IL thunk is already cached on DelegateEE… 

    …Class
    @tomeksowi
    tomeksowi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b9201b1 View commit details
    Browse the repository at this point in the history

  4. Fix shuffle thunk destruction in EEClass::Destruct: properly handle I… 

    …L shuffle thunks and call RemoveStubRange if m_pInstRetBuffCallStub was deleted
    @tomeksowi
    tomeksowi committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e41802f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Don't use RemoveStubRange in the destructor, make code for dereferenc… 

    …ing shuffle thunk when caching fails the same as destructor
    @tomeksowi
    tomeksowi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    118f191 View commit details
    Browse the repository at this point in the history

  2. Remove unused RemoveStubRange

    @tomeksowi
    tomeksowi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5832103 View commit details
    Browse the repository at this point in the history

  3. Cover IL shuffle thunks in ILStubManager::TraceManager

    @tomeksowi
    tomeksowi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7fe3c4e View commit details
    Browse the repository at this point in the history

  4. Remove unused start, end arguments from RangeList::RemoveRanges[Worker]

    @tomeksowi
    tomeksowi committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    659a9e4 View commit details
    Browse the repository at this point in the history

  5. Update src/coreclr/vm/comdelegate.cpp

    @jkotas
    jkotas authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ccf1e4e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into fp-structs-shuffling-thunks

    @tomeksowi
    tomeksowi authored Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e45db16 View commit details
    Browse the repository at this point in the history