[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

tomeksowi · 2024-09-03T08:39:52Z

Properly implements the transfer of arguments between integer and hardware floating-point calling conventions (i.e. lowering and delowering) in shuffling thunks. The hitherto implementation was lacking in several ways:

used fld (8-byte) to shuffle float from stack to register, which is wrong because the stack slot is not NaN-boxed
did not support FP structs passed in one stack slot
did not respect size and offsets of FP struct fields in general
did not support shuffling stack slots to the right (when the delowered FP struct was larger than the lowered one but there was another lowering)
did not support the case when the shuffling thunk must allocate stack space (the above case but without the second lowering)

The new implementation does away with the omnibus loop in StubLinkerCPU::EmitShuffleThunk in favor of tighter case-by-case loops. That way shuffling all within integer calling convention (vast majority of cases) is simple and the more involved cases with calling convention transfers are complete while still not needing all-out graph sorting.

Note: this PR is about correctness, optimization TODOs will not be pursued here.

Stems from #101796, part of #84834, cc @dotnet/samsung

…nstead of an omnibus loop handling ShuffleEntries

…pStructs. EmptyStructs test passes except for ShufflingThunk_FloatEmptyShort_DoubleFloatNestedEmpty_RiscV

…Regressions/coreclr/GitHub_16833/Test16833

…he key points first, which simplifies code and solves some corner cases e.g. where we can't assume struct stack size by checking the size + offset of the last field

jkotas · 2024-09-28T21:08:44Z

Release-build FAILED

Is this build failure something to worry about?

sirntar · 2024-09-30T06:32:11Z

Release-build FAILED

Is this build failure something to worry about?

Not really, it's an infrastructure failure. I was sick last week so I couldn't fix it. I'm looking into it now, but these errors are not related to this PR.

…Cache the generated thunk on DelegateEEClass

…ing the signature from target method to retain type context

risc-vv · 2024-10-03T10:21:00Z

RISC-V Release-CLR-QEMU: 9419 / 9435 (99.83%)

=======================
      passed: 9419
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 58min 16s 879ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 578732 / 615483 (94.03%)

=======================
      passed: 578732
      failed: 252
     skipped: 1578
      killed: 36499
------------------------
  TOTAL libs: 257
 TOTAL tests: 617061
   REAL time: 2h 21min 45s 24ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 9321b07e4fc8c1a3824101c00ec3018b631a1853
CI: 4b73274d968851952b4a1be8a8869fe4aed3d960
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-QEMU: 9419 / 9435 (99.83%)

=======================
      passed: 9419
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 57min 58s 766ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 578732 / 615483 (94.03%)

=======================
      passed: 578732
      failed: 252
     skipped: 1578
      killed: 36499
------------------------
  TOTAL libs: 257
 TOTAL tests: 617061
   REAL time: 2h 21min 45s 24ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 9321b07e4fc8c1a3824101c00ec3018b631a1853
CI: 4b73274d968851952b4a1be8a8869fe4aed3d960
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9419 / 9435 (99.83%)

=======================
      passed: 9419
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 2h 57min 53s 113ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 495878 / 548882 (90.34%)

=======================
      passed: 495878
      failed: 22
     skipped: 1466
      killed: 52982
------------------------
  TOTAL libs: 257
 TOTAL tests: 550348
   REAL time: 2h 24min 0s 717ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 9321b07e4fc8c1a3824101c00ec3018b631a1853
CI: 4b73274d968851952b4a1be8a8869fe4aed3d960
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9419 / 9435 (99.83%)

=======================
      passed: 9419
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 3h 3min 26s 407ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 495878 / 548882 (90.34%)

=======================
      passed: 495878
      failed: 22
     skipped: 1466
      killed: 52982
------------------------
  TOTAL libs: 257
 TOTAL tests: 550348
   REAL time: 2h 24min 0s 717ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 9321b07e4fc8c1a3824101c00ec3018b631a1853
CI: 4b73274d968851952b4a1be8a8869fe4aed3d960
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

risc-vv · 2024-10-03T11:45:59Z

RISC-V Release-CLR-QEMU: 9419 / 9435 (99.83%)

=======================
      passed: 9419
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 57min 58s 766ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 582496 / 609283 (95.60%)

=======================
      passed: 582496
      failed: 233
     skipped: 1582
      killed: 26554
------------------------
  TOTAL libs: 257
 TOTAL tests: 610865
   REAL time: 2h 25min 16s 731ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: 5e1455c118d947c0413452ece4b2b2a3eec6ceff
CI: 4b73274d968851952b4a1be8a8869fe4aed3d960
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-CLR-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R "/godata/pipelines/Release-FX-QEMU/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9419 / 9435 (99.83%)

=======================
      passed: 9419
      failed: 1
     skipped: 107
      killed: 15
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 3h 3min 26s 407ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 549039 / 591088 (92.89%)

=======================
      passed: 549039
      failed: 22
     skipped: 1464
      killed: 42027
------------------------
  TOTAL libs: 257
 TOTAL tests: 592552
   REAL time: 2h 18min 22s 848ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: 5e1455c118d947c0413452ece4b2b2a3eec6ceff
CI: 4b73274d968851952b4a1be8a8869fe4aed3d960
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R "/var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release"/* "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

src/coreclr/vm/comdelegate.cpp

src/coreclr/vm/dllimport.h

src/coreclr/vm/ilstubcache.cpp

src/coreclr/vm/comdelegate.cpp

…tubMethodName

…Class

risc-vv · 2024-10-08T10:31:13Z

b9201b1 is being scheduled for building and testing

GIT: b9201b1ebd8114964786b8b4fbceb23eaa141fef
REPO: dotnet/runtime
BRANCH: main

src/coreclr/vm/comdelegate.cpp

…L shuffle thunks and call RemoveStubRange if m_pInstRetBuffCallStub was deleted

risc-vv · 2024-10-08T13:46:02Z

RISC-V Release-CLR-VF2: 9435 / 9435 (100.00%)

=======================
      passed: 9435
      failed: 0
     skipped: 107
      killed: 0
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 3h 4min 36s 774ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 518744 / 561957 (92.31%)

=======================
      passed: 518744
      failed: 13
     skipped: 1465
      killed: 43200
------------------------
  TOTAL libs: 257
 TOTAL tests: 563422
   REAL time: 2h 28min 20s 118ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: e41802f69c72a58a367cc7de3842d7e9cb31462f
CI: dc902f49321bed295468a88446a438c5621f465b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-VF2: 9435 / 9435 (100.00%)

=======================
      passed: 9435
      failed: 0
     skipped: 107
      killed: 0
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 3h 5min 25s 894ms
=======================

Release-CLR-VF2.md, Release-CLR-VF2.xml, testclr_output.tar.gz

RISC-V Release-FX-VF2: 518744 / 561957 (92.31%)

=======================
      passed: 518744
      failed: 13
     skipped: 1465
      killed: 43200
------------------------
  TOTAL libs: 257
 TOTAL tests: 563422
   REAL time: 2h 28min 20s 118ms
=======================

Release-FX-VF2.md, Release-FX-VF2.xml, testfx_output.tar.gz

Build information and commands

GIT: e41802f69c72a58a367cc7de3842d7e9cb31462f
CI: dc902f49321bed295468a88446a438c5621f465b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/var/lib/go-agent/pipelines/Release-CLR-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-CLR-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-CLR-VF2/testhost.Release/dotnet CORE_ROOT=/var/lib/go-agent/pipelines/Release-CLR-VF2/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 8 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/var/lib/go-agent/pipelines/Release-FX-VF2/logs/run_tests.log
cp -R /var/lib/go-agent/pipelines/Release-FX-VF2/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && __TestDotNetCmd=/var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /var/lib/go-agent/pipelines/Release-FX-VF2/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-QEMU: 9435 / 9435 (100.00%)

=======================
      passed: 9435
      failed: 0
     skipped: 107
      killed: 0
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 58min 16s 176ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 586791 / 627093 (93.57%)

=======================
      passed: 586791
      failed: 231
     skipped: 1582
      killed: 40071
------------------------
  TOTAL libs: 257
 TOTAL tests: 628675
   REAL time: 2h 20min 54s 553ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: e41802f69c72a58a367cc7de3842d7e9cb31462f
CI: dc902f49321bed295468a88446a438c5621f465b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R /godata/pipelines/Release-CLR-QEMU/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R /godata/pipelines/Release-FX-QEMU/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

RISC-V Release-CLR-QEMU: 9435 / 9435 (100.00%)

=======================
      passed: 9435
      failed: 0
     skipped: 107
      killed: 0
------------------------
  TOTAL libs: 9542
 TOTAL tests: 9542
   REAL time: 58min 16s 216ms
=======================

Release-CLR-QEMU.md, Release-CLR-QEMU.xml, testclr_output.tar.gz

RISC-V Release-FX-QEMU: 586791 / 627093 (93.57%)

=======================
      passed: 586791
      failed: 231
     skipped: 1582
      killed: 40071
------------------------
  TOTAL libs: 257
 TOTAL tests: 628675
   REAL time: 2h 20min 54s 553ms
=======================

Release-FX-QEMU.md, Release-FX-QEMU.xml, testfx_output.tar.gz

Build information and commands

GIT: e41802f69c72a58a367cc7de3842d7e9cb31462f
CI: dc902f49321bed295468a88446a438c5621f465b
REPO: dotnet/runtime
BRANCH: main
CONFIG: Release
LIB_CONFIG: Release

# CORE_LIBS_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s libs /p:EnableSourceLink=false
# CORE_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -s clr+libs+host /p:EnableSourceLink=false

# TESTCLR_BUILD_CMD
runtime/src/tests/build.sh -riscv64 -cross -Release -priority1 -p:UseLocalAppHostPack=true
# TESTCLR_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --core_root ./coreclr.Release/Tests/Core_Root --testhost ./testhost.Release --atest ./coreclr.Release --test ./ --log_dir ./logs  --timeout 2700 --log_level DEBUG --xunit xunit.Release
# TESTCLR_RUN
/godata/pipelines/Release-CLR-QEMU/logs/run_tests.log
cp -R /godata/pipelines/Release-CLR-QEMU/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-CLR-QEMU/testhost.Release/dotnet CORE_ROOT=/godata/pipelines/Release-CLR-QEMU/coreclr.Release/Tests/Core_Root  /usr/bin/time -f "exec_time: %e" ./_TEST_BINARY_

# TESTFX_BUILD_CMD
runtime/build.sh --arch riscv64 --cross -c Release -rc Release -hc Release -lc Release -s libs.tests --testscope innerloop /p:EnableSourceLink=false /p:UseLocalAppHostPack=true
# TESTFX_CMD
python3 riscv-CI/goci/agent/TestRunner/run.py --corefx --testhost ./testhost.Release --atest ./corefx.Release --log_dir ./logs  --timeout 6000 --memlimit 4096 --jobs 16 --log_level DEBUG --xunit xunit.Release
# TESTFX_RUN
/godata/pipelines/Release-FX-QEMU/logs/run_tests.log
cp -R /godata/pipelines/Release-FX-QEMU/xunit.Release "/_PATH_/_WITH_/_TEST_"/ ; cd "/_PATH_/_WITH_/_TEST_" && ROOTFS_DIR=/crossrootfs/riscv64 QEMU_LD_PREFIX=/crossrootfs/riscv64 __TestDotNetCmd=/godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet  /usr/bin/time -f "exec_time: %e" /godata/pipelines/Release-FX-QEMU/testhost.Release/dotnet exec   xunit.console.dll _TEST_BINARY_ -nologo -nocolor -notrait category=failing

# TEST_ENV
DOTNET_JitStress=;DOTNET_JitStressRegs=;DOTNET_GCStress=;DOTNET_JITMinOpts=;DOTNET_TailcallStress=;DOTNET_TieredCompilation=

src/coreclr/vm/comdelegate.cpp

src/coreclr/vm/class.cpp

…ing shuffle thunk when caching fails the same as destructor

risc-vv · 2024-10-09T06:50:55Z

7fe3c4e is being scheduled for building and testing

GIT: 7fe3c4e280859c42f84e3d469a1390425994c8b3
REPO: dotnet/runtime
BRANCH: main

Release-CLR-build FAILED

buildinfo.json

Compilation failed during coreclr-tests build```

</details><details>
<summary>Release-CLR-build FAILED</summary>

[buildinfo.json](https://gist.githubusercontent.com/risc-vv/6411da95b7ae685527b4b3b006589c09/raw/5b5e8e923238ab703922c2d51656bee8b3df98ed/7fe3c4e2_buildinfo.json)
```bash
Compilation failed during coreclr-tests build```

</details>

risc-vv · 2024-10-09T07:16:04Z

659a9e4 is being scheduled for building and testing

GIT: 659a9e4a4327e17a78389dd1146da5a2b09688c5
REPO: dotnet/runtime
BRANCH: main

Release-CLR-build FAILED

buildinfo.json

Compilation failed during coreclr-tests build```

</details>

src/coreclr/vm/comdelegate.cpp

risc-vv · 2024-10-09T10:11:01Z

ccf1e4e is being scheduled for building and testing

GIT: ccf1e4e41dd453d443542f8db6dbe453baf20859
REPO: dotnet/runtime
BRANCH: main

Release-build FAILED

buildinfo.json

Compilation failed during core build```

</details>

am11 · 2024-10-09T10:27:58Z

src/tasks/installer.tasks/installer.tasks.csproj(0,0): error NU1903: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Package 'System.Text.Json' 8.0.4 has a known high severity vulnerability, GHSA-8g4q-xg66-9fp4

Not sure why it has started to fail just now, but the fix is to update this to 8.0.5

runtime/eng/Versions.props

Line 139 in abde3f9

tomeksowi added 26 commits August 28, 2024 14:48

Log ShuffleEntries from GenerateShuffleArray

70cf57f

Add failing tests for passing FP structs through shuffling thunks

1377172

Report proper ShuffleEntries for lowered FP structs

1cec66b

Implement shuffling thunk generation in tighter, more focused loops i…

329321b

…nstead of an omnibus loop handling ShuffleEntries

Generate ShuffleEntries for delowered arguments

9a50786

Better ShuffleEntry mask names, one more bit for field offset

87c8397

Fix FpStruct for dst arg loc

8b3b470

Fold ShuffleEntry generation code for lowering and delowering FpStructs

1a14067

ShuffleEntry mask doc update

6fa6d18

Implement forward shuffling of floating registers and delowering of F…

114583a

…pStructs. EmptyStructs test passes except for ShufflingThunk_FloatEmptyShort_DoubleFloatNestedEmpty_RiscV

Fix shuffling of integer registers for member functions

331d77e

The delowered argument can also be put in the first stack slot

1d96d11

Stask shuffling after delowered argument doesn't start with 0. Fixes …

30edbc5

…Regressions/coreclr/GitHub_16833/Test16833

Code cleanup, fewer indents

a445275

Support second lowering

bec2d89

Remove unused CondCode

83dee89

Handle stack slot shuffling to the right

b1466a0

Add some stack slots to shuffle in the growing stack test case

6a7d2ce

Fix Equals signature on test structs

bb28b72

Remodel the shuffling with calling convention transfer to recognize t…

dbb5338

…he key points first, which simplifies code and solves some corner cases e.g. where we can't assume struct stack size by checking the size + offset of the last field

Use helper functions in EmitComputedInstantiatingMethodStub

68e0c36

Implement stack growing in shuffling thunk

015aed0

Use signed immediate in EmitSubImm to be consistent with EmitAddImm

3dcc74c

Use ABI register names in logs

afdec48

Remove LoadRegPair because it's not used

84bffa4

Add logging for slli and lui

de61b96

dotnet-issue-labeler bot added the area-VM-coreclr label Sep 3, 2024

dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 3, 2024

clamp03 assigned tomeksowi Sep 3, 2024

clamp03 added the arch-riscv Related to the RISC-V architecture label Sep 3, 2024

tomeksowi added 4 commits October 1, 2024 14:28

IL shuffle thunk takes target function address from delegate object. …

a008f20

…Cache the generated thunk on DelegateEEClass

Build target signature based on delegate signature instead of just us…

2900dfb

…ing the signature from target method to retain type context

Test calling instance and static methods via the same delegate type

fe5d775

Simplify shuffle thunk caching on DelegateEEClass

9321b07

Clean up CreateILDelegateShuffleThunk

5e1455c

tomeksowi requested a review from jkotas October 4, 2024 01:06

jkotas reviewed Oct 8, 2024

View reviewed changes

tomeksowi added 3 commits October 8, 2024 10:50

Delete Windows X86 stack size check

ec1c57a

Remove #ifdefs around ILSTUB_DELEGATE_SHUFFLE_THUNK, fix typo in GetS…

27c005f

…tubMethodName

Fix DecRef'ing path when the IL thunk is already cached on DelegateEE…

b9201b1

…Class

jkotas reviewed Oct 8, 2024

View reviewed changes

src/coreclr/vm/comdelegate.cpp Outdated Show resolved Hide resolved

Fix shuffle thunk destruction in EEClass::Destruct: properly handle I…

e41802f

…L shuffle thunks and call RemoveStubRange if m_pInstRetBuffCallStub was deleted

jkotas reviewed Oct 8, 2024

View reviewed changes

tomeksowi added 3 commits October 9, 2024 08:38

Don't use RemoveStubRange in the destructor, make code for dereferenc…

118f191

…ing shuffle thunk when caching fails the same as destructor

Remove unused RemoveStubRange

5832103

Cover IL shuffle thunks in ILStubManager::TraceManager

7fe3c4e

Remove unused start, end arguments from RangeList::RemoveRanges[Worker]

659a9e4

jkotas reviewed Oct 9, 2024

View reviewed changes

src/coreclr/vm/comdelegate.cpp Outdated Show resolved Hide resolved

Update src/coreclr/vm/comdelegate.cpp

ccf1e4e

am11 mentioned this pull request Oct 9, 2024

Update SystemTextJsonToolsetVersion #108704

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

tomeksowi commented Sep 3, 2024

jkotas commented Sep 28, 2024

sirntar commented Sep 30, 2024

risc-vv commented Oct 3, 2024 •

edited

Loading

risc-vv commented Oct 3, 2024 •

edited

Loading

risc-vv commented Oct 8, 2024

risc-vv commented Oct 8, 2024 •

edited

Loading

risc-vv commented Oct 9, 2024 •

edited

Loading

risc-vv commented Oct 9, 2024 •

edited

Loading

risc-vv commented Oct 9, 2024 •

edited

Loading

am11 commented Oct 9, 2024

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

Are you sure you want to change the base?

[RISC-V] Transfer arguments between calling conventions in shuffling thunks #107282

Conversation

tomeksowi commented Sep 3, 2024

jkotas commented Sep 28, 2024

sirntar commented Sep 30, 2024

risc-vv commented Oct 3, 2024 • edited Loading

risc-vv commented Oct 3, 2024 • edited Loading

risc-vv commented Oct 8, 2024

risc-vv commented Oct 8, 2024 • edited Loading

risc-vv commented Oct 9, 2024 • edited Loading

risc-vv commented Oct 9, 2024 • edited Loading

risc-vv commented Oct 9, 2024 • edited Loading

am11 commented Oct 9, 2024

risc-vv commented Oct 3, 2024 •

edited

Loading

risc-vv commented Oct 3, 2024 •

edited

Loading

risc-vv commented Oct 8, 2024 •

edited

Loading

risc-vv commented Oct 9, 2024 •

edited

Loading

risc-vv commented Oct 9, 2024 •

edited

Loading

risc-vv commented Oct 9, 2024 •

edited

Loading