-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Use SVE1 variants of AddSaturate and SubtractSaturate instructions #106068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SVE1 variants of AddSaturate and SubtractSaturate instructions #106068
Conversation
Stress tests are passing now |
a74nh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM to me.
Slightly different fix than multiply.
For multiply, the predicated version is SVE1, unpredicated is SVE2.
For AddSaturate, the predicated version is SVE2, unpredicated is SVE1.
amanasifkhalid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too, thanks!
I did a quick parse of Sve.cs, and looks like the comments for these intrinsics were already correct, so we don't need to update anything else.
Fixes: #105799
@a74nh @kunalspathak @dotnet/arm64-contrib @TIHan @amanasifkhalid