Skip to content

Conversation

@SwapnilGaikwad
Copy link
Contributor

@SwapnilGaikwad SwapnilGaikwad commented Aug 5, 2024

Fixes: #105736

Using the predicated version as the unpredicated MUL is SVE2 only

@a74nh @kunalspathak @dotnet/arm64-contrib

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 5, 2024
@SwapnilGaikwad SwapnilGaikwad marked this pull request as ready for review August 6, 2024 09:44
@SwapnilGaikwad
Copy link
Contributor Author

All stress tests are passing now
===================Running default===================
------------------- {} -------------------
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_float() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_double() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_sbyte() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_short() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_int() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_long() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_byte() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_ushort() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_uint() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_Multiply_ulong() : 31
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_sbyte() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_short() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_int() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_long() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_byte() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_ushort() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_uint() : 37
Passed test: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_MultiplyAdd_ulong() : 37
===================Running jitstress===================
------------------- {'JitMinOpts': '1'} -------------------
------------------- {'JitStress': '1'} -------------------
------------------- {'JitStress': '2'} -------------------
------------------- {'JitStress': '1', 'TieredCompilation': '1'} -------------------
------------------- {'JitStress': '2', 'TieredCompilation': '1'} -------------------
------------------- {'TailcallStress': '1'} -------------------
------------------- {'ReadyToRun': '0'} -------------------
===================Running jitstressregs===================
------------------- {'JitStressRegs': '1'} -------------------
------------------- {'JitStressRegs': '2'} -------------------
------------------- {'JitStressRegs': '3'} -------------------
------------------- {'JitStressRegs': '4'} -------------------
------------------- {'JitStressRegs': '8'} -------------------
------------------- {'JitStressRegs': '0x10'} -------------------
------------------- {'JitStressRegs': '0x80'} -------------------
------------------- {'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStressRegs': '0x2000'} -------------------
===================Running jitstress2-jitstressregs===================
------------------- {'JitStress': '2', 'JitStressRegs': '1'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '2'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '3'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '4'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '8'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x10'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x80'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x1000'} -------------------
------------------- {'JitStress': '2', 'JitStressRegs': '0x2000'} -------------------

@SwapnilGaikwad
Copy link
Contributor Author

@TIHan @amanasifkhalid

Copy link
Contributor

@amanasifkhalid amanasifkhalid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@a74nh in #105736, were you able to run all the SVE tests after the Multiply ones on your machine? If not, it might be a good idea to see if there are any other SVE2 instructions sneaking in.

@a74nh
Copy link
Contributor

a74nh commented Aug 6, 2024

LGTM, thanks!

@a74nh in #105736, were you able to run all the SVE tests after the Multiply ones on your machine? If not, it might be a good idea to see if there are any other SVE2 instructions sneaking in.

There's also #105799 but everything else looks good.

@amanasifkhalid amanasifkhalid merged commit 8d7e3b5 into dotnet:main Aug 6, 2024
@SwapnilGaikwad SwapnilGaikwad deleted the github-fix-sve-multiply branch August 7, 2024 08:47
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arm64/Sve: Sve_Multiply tests failing

3 participants