Implement Activity.AddLink #101381
Merged
Implement Activity.AddLink #101381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonfirsov
added
NO-MERGE
|
Note regarding the |
It's not marked as api ready for review, or even api suggestion... it's not going to show up on anyone's api approval radar. |
|
I am closing this till we review and approve the API. We can reactivate after then. |
|
I marked #97680 as ready for review. |
This was referenced Apr 22, 2024
Closed
tarekgh
removed
the
NO-MERGE
stephentoub
reviewed
Apr 23, 2024
src/libraries/System.Diagnostics.DiagnosticSource/tests/ActivityTests.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Apr 23, 2024
Closed
This was referenced Apr 24, 2024
lmolkova
approved these changes
Apr 24, 2024
|
@antonfirsov could you please merge the main branch to yours to proceed with this PR? Thanks! |
This was referenced Apr 24, 2024
Closed
Closed
matouskozak
pushed a commit
to matouskozak/runtime
that referenced
this pull request
Apr 30, 2024
* implement Activity.AddLink * extend tests * Add remarks to docs required by https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#link
michaelgsharp
pushed a commit
to michaelgsharp/runtime
that referenced
this pull request
May 9, 2024
* implement Activity.AddLink * extend tests * Add remarks to docs required by https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/api.md#link
tarekgh
referenced
this pull request
in dotnet/core
May 24, 2024
* Fix Tokenizer Preview 4 Release Notes * remove extra empty line * Remove un-needed line
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #97680 assuming the API will be approved, marking as NO-MERGE until then.