-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better OTel information into Brighter #3096
Conversation
…irectly, and override usage of the factory if so.
It is worth noting the following: | ||
|
||
* The `BulkMessageMap` is a bulk, iterative operation; it's main purpose is late-binding of the type from an `IEnumerable<IRequest>` | ||
* Producing a `Message` via a `Producer` is not a bulk operation in Brighter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brighter v9 does support Bulk clearing via the IAmABulkMessageProducerAsync
interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look, although we have not made changes to clear along these lines yet
* The `BulkMessageMap` is a bulk, iterative operation; it's main purpose is late-binding of the type from an `IEnumerable<IRequest>` | ||
* Producing a `Message` via a `Producer` is not a bulk operation in Brighter | ||
|
||
The only bulk operations we have in the flow are the read and write from the `Outbox` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In v9 there is also a Bulk Mark Dispatches via the MarkDispatchedAsync(IEnumerable ids, ...) method on the relational outbox
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, we won't have changed that
@iancooper Talking about bulk I see a couple of Paths here, Generally I use implicit clearing of the outbox so in my application code I am only ever doing a Bulk outbox add (where necessary). The most important flow in my mind is the Bulk dispatch of messages, at the moment if we consider a batch of 100 messages that are to be dispatched: Without Bulk Dispatch
In this instance we have
This is very slow, in my experience dispatching from the outbox is slower than consuming (from memory it was around a message or two a second) so no active messages end up on the queue The same example above with Bulk (as is currently functioning in v9 for MsSql and ASB)
In this instance we have
Using this method I have successfully been able to dispatch a very large weight of messages (>100k) in well under a minute. Without the ability to bulk dispatch my system will not work (we dispatch millions of messages per day) |
Not altered here. I'll pick up batches after. It would be good to support both batch writes to the outbox and batch read and write to producer. There is a V10 change because we need the publication for the pipeline, so that we can use it for CloudEvents (and its there for generic mappers) so we do publication lookup when we run the transform/mapping pipeline. That means we would need to do something a little different for deposit post as I moved the late binding earlier. But the clear, I am still looking at |
Excellent, as long as in the Deposit Flow we can do a single Command for insert this will be excellent! let me know if there are any parts you want me to look at |
* Update ADR * Update 0011-brighter-support-for-bulk-messaging-operations.md
feat: span tests for clear
…ue to deadlock risks
@preardon As discussed going to merge. It is not complete, but it should work.
Those will be in further PRs |
We created semantic conventions for Brighter: https://github.com/BrighterCommand/Brighter/blob/master/docs/adr/0010-brighter-semantic-conventions.md
This PR is about adding those conventions into Brighter.